GH-711: Review Two by bertllll · Pull Request #568 · MASQ-Project/Node

bertllll · 2025-01-03T20:23:34Z

No description provided.

…, next I should check if the test is still passing

…ion and can be left as done

…sions, adjustment runners)

…ion, disqualification_arbiter and helper_functions

…id of the adjustment runners

…ts (to enable easier understanding)

node/src/accountant/scanners/mod.rs

node/src/accountant/test_utils.rs

utkarshg6

Continue with the new file: node/src/accountant/payment_adjuster/non_unit_tests/mod.rs

node/src/accountant/payment_adjuster/non_unit_tests/mod.rs

utkarshg6

Continue at node/src/accountant/payment_adjuster/non_unit_tests/mod.rs:307

node/src/accountant/payment_adjuster/non_unit_tests/mod.rs

utkarshg6

Continue at node/src/accountant/payment_adjuster/non_unit_tests/mod.rs:391

node/src/accountant/payment_adjuster/non_unit_tests/mod.rs

utkarshg6

Continue with the new file node/src/accountant/payment_adjuster/mod.rs

node/src/accountant/payment_adjuster/mod.rs

utkarshg6

node/src/accountant/payment_adjuster/mod.rs:1093

node/src/accountant/payment_adjuster/mod.rs

utkarshg6

Done! 👍

Bert and others added 30 commits September 13, 2024 21:58

GH-711: first fixes from the review...finalizing 'Percentage'

dc4d63b

GH-711: Pecentage looks done

ea7380e

GH-711: First handful of changes for verify_bill_payment

d540732

GH-711: verify_bill_payments significant improvement in arrangement

53da726

Merge branch 'GH-711-addressing-review-1' into GH-711-review-one

271e8f9

GH-711-review-one: adding directives to ignore files

d4c15bd

GH-711-review-one: more work done on verify_bill_payments; savepoint

f192424

GH-711-review-one: Decent version of verify_bill_payments

baf51c4

GH-711-review-one: interim commit

eedf9ce

GH-711-review-one: the revamp of the verify_bill_payment is finishing…

a9f86ae

…, next I should check if the test is still passing

GH-711-review-one: minor clean-up

9067c8c

GH-711-review-one: tests in verify_bill_payments are in a fine condit…

6bb13e7

…ion and can be left as done

GH-711-review-one: mid-scan space more ergonomical by code

788c1f5

GH-711-review-one: a few more comments kncoked off in Accountant

bb207cd

GH-711-review-one: accountant/mod.rs finished

5cfc84f

GH-711-review-one: more comments swept off after work done

5561d3d

GH-711-review-one: another chunk of repairs (logging fns, type conver…

5e397f4

…sions, adjustment runners)

GH-711-review-one: more repairs in data_structures, accounts_abstract…

719d701

…ion, disqualification_arbiter and helper_functions

GH-711-review-one: interim commit

bc15ac9

GH-711-review-one: helper functions repaired

b73f96e

GH-711-review-one: interim commit

a1f97de

GH-711-review-one: big refactoring in the mod.rs file, also getting r…

2a36919

…id of the adjustment runners

GH-711-review-one: interim commit

e6c817c

GH-711-review-one: new fixes in the main mod

bf272f5

GH-711-review-one: interim commit

dc69d86

GH-711-review-one: interim commit

00e0cbe

GH-711-review-one: interim commit

7cec579

GH-711-review-one: tests with more illustrative disqualification limi…

e99725b

…ts (to enable easier understanding)

GH-711-review-one: more tests repaired

bfdcf97

GH-711-review-one: mod.rs taken care of fully

490fe96

utkarshg6 reviewed Feb 18, 2025

View reviewed changes

node/src/accountant/scanners/mod.rs Show resolved Hide resolved

utkarshg6 reviewed Feb 18, 2025

View reviewed changes

node/src/accountant/scanners/mod.rs Show resolved Hide resolved

utkarshg6 reviewed Feb 18, 2025

View reviewed changes

node/src/accountant/test_utils.rs Show resolved Hide resolved

utkarshg6 reviewed Feb 18, 2025

View reviewed changes

utkarshg6 reviewed Feb 19, 2025

View reviewed changes