GH-711: Review Two#568

Open

bertllll wants to merge 48 commits intoGH-711-review-one-saved-statefrom

GH-711-review-one

Commits on Sep 13, 2024

GH-711: first fixes from the review...finalizing 'Percentage'

Bert
authored and
Bert
committed
GH-711: Pecentage looks done

Bert
authored and
Bert
committed

Commits on Sep 16, 2024

GH-711: First handful of changes for verify_bill_payment

Bert
authored and
Bert
committed

Commits on Sep 19, 2024

GH-711: verify_bill_payments significant improvement in arrangement

Bert
authored and
Bert
committed
Merge branch 'GH-711-addressing-review-1' into GH-711-review-one

Bert
authored and
Bert
committed
GH-711-review-one: adding directives to ignore files

Bert
authored and
Bert
committed

Commits on Sep 21, 2024

GH-711-review-one: more work done on verify_bill_payments; savepoint

Bert
authored and
Bert
committed

Commits on Sep 22, 2024

GH-711-review-one: Decent version of verify_bill_payments

Bert
authored and
Bert
committed
GH-711-review-one: interim commit

Bert
authored and
Bert
committed

Commits on Sep 25, 2024

GH-711-review-one: the revamp of the verify_bill_payment is finishing, next I should check if the test is still passing

Bert
authored and
Bert
committed

Commits on Oct 2, 2024

GH-711-review-one: minor clean-up

Bert
authored and
Bert
committed
GH-711-review-one: tests in verify_bill_payments are in a fine condition and can be left as done

Bert
authored and
Bert
committed

Commits on Oct 5, 2024

GH-711-review-one: mid-scan space more ergonomical by code

Bert
authored and
Bert
committed
GH-711-review-one: a few more comments kncoked off in Accountant

Bert
authored and
Bert
committed

Commits on Oct 6, 2024

GH-711-review-one: accountant/mod.rs finished

Bert
authored and
Bert
committed
GH-711-review-one: more comments swept off after work done

Bert
authored and
Bert
committed

Commits on Oct 24, 2024

GH-711-review-one: another chunk of repairs (logging fns, type conversions, adjustment runners)

Bert
authored and
Bert
committed

Commits on Oct 25, 2024

GH-711-review-one: more repairs in data_structures, accounts_abstraction, disqualification_arbiter and helper_functions
bertllll
committed

Commits on Oct 29, 2024

GH-711-review-one: interim commit
bertllll
committed

Commits on Nov 4, 2024

Commits on Nov 5, 2024

GH-711-review-one: interim commit
bertllll
committed

Commits on Nov 10, 2024

GH-711-review-one: new fixes in the main mod

Bert
authored and
Bert
committed
GH-711-review-one: interim commit

Bert
authored and
Bert
committed

Commits on Nov 14, 2024

GH-711-review-one: interim commit

Bert
authored and
Bert
committed

Commits on Dec 5, 2024

GH-711-review-one: interim commit

Bert
authored and
Bert
committed
GH-711-review-one: tests with more illustrative disqualification limits (to enable easier understanding)

Bert
authored and
Bert
committed

Commits on Dec 6, 2024

GH-711-review-one: more tests repaired

Bert
authored and
Bert
committed

Commits on Dec 7, 2024

GH-711-review-one: mod.rs taken care of fully

Bert
authored and
Bert
committed
GH-711-review-one: interim commit

Bert
authored and
Bert
committed
GH-711-review-one: more improvements

Bert
authored and
Bert
committed

Commits on Dec 11, 2024

GH-711-review-one: using much multipliers for more ergonomiv number writes...and other stuff

Bert
authored and
Bert
committed
GH-711-review-one: more little improvements; the fuzz test

Bert
authored and
Bert
committed

Commits on Dec 12, 2024

GH-711-review-one: refactoring in the fuzz test

Bert
authored and
Bert
committed

Commits on Dec 13, 2024

GH-711-review-one: finished refactoring the fuzz test

Bert
authored and
Bert
committed

Commits on Dec 14, 2024

GH-711-review-one: interim commit
bertllll
committed

Commits on Dec 23, 2024

GH-711: a few more little fixes
bertllll
committed

Commits on Dec 27, 2024

GH-711: repaired panic messages
bertllll
committed

Commits on Dec 28, 2024

GH-711: some harsh modification for older auxiliary test structures
bertllll
committed

Commits on Dec 29, 2024

GH-711: this is almost the last batch out of the comments in the review
bertllll
committed

Commits on Jan 2, 2025

GH-711: last case of repair before wallet -> address
bertllll
committed

Commits on Jan 3, 2025

GH-711-review-one: everything in the review addressed

Bert
authored and
Bert
committed
GH-711-review-one: after ci/all.sh

Bert
authored and
Bert
committed