A couple more CSP enhancements #2530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-tchad
requested review from
labkey-adam,
a team and
labkey-danield
and removed request for
a team
3 tasks
labkey-adam
approved these changes
Jul 3, 2025
| public void testEmbeddedReportNonce() | ||
| { | ||
| CspConfigHelper.debugCspWarnings(); | ||
| new CspConfigHelper(this).setEnforceCsp(false); |
There was a problem hiding this comment.
So we're still disabling the enforce CSP and checking for logged warnings?
There was a problem hiding this comment.
I suppose we don't have to now that you mention it.
I'll remove these in a separate PR after this is merged. I don't want to touch this branch since it is merging to 25.7 but TeamCity is running it against develop.
labkey-chrisj
approved these changes
Jul 7, 2025
This was referenced Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Add test coverage for CSP enhancements
Related Pull Requests
Changes
CspLogUtilAbstractKnitrReportTest)PortalHelperWikiHelpertowiki.EditPage