Skip to content

Don't disable CSP enforcement for knitr tests #2554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 11, 2025
Merged

Don't disable CSP enforcement for knitr tests #2554

merged 3 commits into from
Jul 11, 2025

Conversation

labkey-tchad
Copy link
Member

Rationale

  1. AbstractKnitrReportTest
    new CspConfigHelper(this).setEnforceCsp(false) doesn't work on trial instances. It isn't really necessary for this test though.
java.lang.NullPointerException: Unable to configure enforce CSP.
  at java.base/java.util.Objects.requireNonNull(Objects.java:336)
  at org.labkey.test.util.core.admin.CspConfigHelper.setEnforceCsp(CspConfigHelper.java:70)
  at org.labkey.test.tests.AbstractKnitrReportTest.testEmbeddedReportNonce(AbstractKnitrReportTest.java:248)

Related Pull Requests

Changes

  • Don't disable CSP enforcement for knitr tests

@labkey-tchad labkey-tchad requested review from a team, labkey-chrisj and labkey-danield and removed request for a team July 11, 2025 16:50
@labkey-tchad labkey-tchad merged commit 6fc4ab3 into release25.7-SNAPSHOT Jul 11, 2025
7 of 8 checks passed
@labkey-tchad labkey-tchad deleted the 25.7_fb_someTestFixes branch July 11, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkey-danield labkey-danield labkey-danield approved these changes

@labkey-chrisj labkey-chrisj Awaiting requested review from labkey-chrisj labkey-chrisj was automatically assigned from LabKey/core-test

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@labkey-tchad @labkey-danield