Skip to content

Allow ScriptReportPage.saveReport to return null #2546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2025

Conversation

labkey-tchad
Copy link
Member

Rationale

Sometimes the reportId parameter for a script report is prefixed with a data region name. getReportId needs to iterate through the parameters to find the right one.

java.lang.NullPointerException: defaultObj
  at java.base/java.util.Objects.requireNonNull(Objects.java:235)
  at java.base/java.util.Objects.requireNonNullElse(Objects.java:290)
  at org.labkey.test.pages.reports.ScriptReportPage.saveReport(ScriptReportPage.java:92)
  at org.labkey.test.pages.reports.ScriptReportPage.saveReport(ScriptReportPage.java:132)
  at org.labkey.test.util.RReportHelper.saveReport(RReportHelper.java:454)

Related Pull Requests

Changes

  • Allow ScriptReportPage.saveReport to return null

@labkey-tchad labkey-tchad requested review from a team and labkey-danield and removed request for a team July 9, 2025 16:45
@labkey-tchad labkey-tchad force-pushed the 25.7_fb_scriptReportPageNpe branch from f2845c2 to 0f21883 Compare July 9, 2025 18:55
@labkey-tchad labkey-tchad merged commit efbfd7b into release25.7-SNAPSHOT Jul 9, 2025
7 checks passed
@labkey-tchad labkey-tchad deleted the 25.7_fb_scriptReportPageNpe branch July 9, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants