Skip to content

Conversation

@g-saracca
Copy link
Contributor

@g-saracca g-saracca commented Apr 30, 2025

What this PR does / why we need it:

Adds a new use case to get the application terms of use (General terms of use in the JSF ui)
After a successful OIDC login from the SPA, an account linking / complete information screen is displayed. At that point, we need to display the Installation Terms Of Use, so we need to obtain them via API.

Which issue(s) this PR closes:

Related Dataverse PRs:

Special notes for your reviewer:

Suggestions on how to test this:

Inspect code and run tests.

Is there a release notes update needed for this change?:

Additional documentation:

@github-actions github-actions bot added GREI Re-arch GREI re-architecture-related SPA.Q2.7 Implement installation terms of use in account linking Waiting labels Apr 30, 2025
@g-saracca g-saracca added Size: 3 A percentage of a sprint. 2.1 hours. Original size: 3 labels Apr 30, 2025
@g-saracca g-saracca moved this to Ready for Review ⏩ in IQSS Dataverse Project Apr 30, 2025
@cmbz cmbz added the FY25 Sprint 22 FY25 Sprint 22 (2025-04-23 - 2025-05-07) label May 1, 2025
@pdurbin
Copy link
Member

pdurbin commented May 1, 2025

Merged!

@ChengShi-1 ChengShi-1 self-requested a review May 5, 2025 13:57
@ChengShi-1 ChengShi-1 moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project May 5, 2025
@ChengShi-1 ChengShi-1 self-assigned this May 5, 2025
Copy link
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! just small tweaks

@g-saracca
Copy link
Contributor Author

@ChengShi-1 changes applied 👍🏼

Copy link
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project May 5, 2025
@ofahimIQSS ofahimIQSS self-assigned this May 5, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project May 5, 2025
@ofahimIQSS
Copy link
Contributor

tests are passing - merging PR

@ofahimIQSS ofahimIQSS merged commit c748a8f into develop May 5, 2025
5 checks passed
@ofahimIQSS ofahimIQSS deleted the feat/293-get-app-terms-of-use branch May 5, 2025 20:29
@github-project-automation github-project-automation bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project May 5, 2025
@ofahimIQSS ofahimIQSS removed their assignment May 5, 2025
@scolapasta scolapasta moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY25 Sprint 22 FY25 Sprint 22 (2025-04-23 - 2025-05-07) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA.Q2.7 Implement installation terms of use in account linking Waiting

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

Get Application Terms of Use Use Case

6 participants