-
Notifications
You must be signed in to change notification settings - Fork 10
Get Application Terms of Use - Use Case #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
849df99
feat: add use case
g-saracca df33a12
docs
g-saracca 92dd276
test: add unit and integration tests
g-saracca fa41668
test: use ghcr image
g-saracca 0160da8
chore: back to unstable image for tests
g-saracca b6ed17d
code review tweaks
g-saracca File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import { UseCase } from '../../../core/domain/useCases/UseCase' | ||
| import { IDataverseInfoRepository } from '../repositories/IDataverseInfoRepository' | ||
|
|
||
| export class GetApplicationTermsOfUse implements UseCase<string> { | ||
| private dataverseInfoRepository: IDataverseInfoRepository | ||
|
|
||
| constructor(dataverseInfoRepository: IDataverseInfoRepository) { | ||
| this.dataverseInfoRepository = dataverseInfoRepository | ||
| } | ||
|
|
||
| /** | ||
| * Returns a string containing the application terms of use. | ||
| * | ||
| * @param {string} [lang] - Optional language parameter to specify the language of the terms of use. | ||
| * @returns {Promise<string>} | ||
| */ | ||
| async execute(lang?: string): Promise<string> { | ||
| return await this.dataverseInfoRepository.getApplicationTermsOfUse(lang) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| import { ReadError } from '../../../src/core/domain/repositories/ReadError' | ||
| import { IDataverseInfoRepository } from '../../../src/info/domain/repositories/IDataverseInfoRepository' | ||
| import { GetApplicationTermsOfUse } from '../../../src/info/domain/useCases/GetApplicationTermsOfUse' | ||
|
|
||
| describe('execute', () => { | ||
| test('should return successful result with terms of use on repository success', async () => { | ||
| const testTermsOfUse = 'Be excellent to each other.' | ||
| const dataverseInfoRepositoryStub: IDataverseInfoRepository = {} as IDataverseInfoRepository | ||
| dataverseInfoRepositoryStub.getApplicationTermsOfUse = jest | ||
| .fn() | ||
| .mockResolvedValue(testTermsOfUse) | ||
| const sut = new GetApplicationTermsOfUse(dataverseInfoRepositoryStub) | ||
|
|
||
| const actual = await sut.execute() | ||
|
|
||
| expect(actual).toBe(testTermsOfUse) | ||
| }) | ||
|
|
||
| test('should return error result on repository error', async () => { | ||
| const dataverseInfoRepositoryStub: IDataverseInfoRepository = {} as IDataverseInfoRepository | ||
| const testReadError = new ReadError() | ||
| dataverseInfoRepositoryStub.getApplicationTermsOfUse = jest | ||
| .fn() | ||
| .mockRejectedValue(testReadError) | ||
| const sut = new GetApplicationTermsOfUse(dataverseInfoRepositoryStub) | ||
|
|
||
| await expect(sut.execute()).rejects.toThrow(ReadError) | ||
| }) | ||
| }) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.