-
Notifications
You must be signed in to change notification settings - Fork 20
Integrate get application terms of use in account linking #677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ofahimIQSS
merged 6 commits into
develop
from
feat/674-integrate-get-application-terms-of-use-in-account-linking
May 6, 2025
Merged
Integrate get application terms of use in account linking #677
ofahimIQSS
merged 6 commits into
develop
from
feat/674-integrate-get-application-terms-of-use-in-account-linking
May 6, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChengShi-1
reviewed
May 5, 2025
Contributor
Author
|
@ChengShi-1 changes applied 👍🏼 |
…of-use-in-account-linking
ChengShi-1
approved these changes
May 6, 2025
Contributor
ChengShi-1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good!
Contributor
Author
|
@ChengShi-1 please approve UI Reviews and UI test 🙏🏼 |
Contributor
|
looks good, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
FY25 Sprint 22
FY25 Sprint 22 (2025-04-23 - 2025-05-07)
GREI Re-arch
GREI re-architecture-related
Original size: 3
Size: 3
A percentage of a sprint. 2.1 hours.
SPA.Q2.7
Implement installation terms of use in account linking
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Integrate the js-dataverse
GetApplicationTermsOfUseuse case.After a successful OIDC login from the SPA, an account linking / complete information screen is displayed. At that point, we need to display the Installation Terms Of Use.
Which issue(s) this PR closes:
Special notes for your reviewer:
The js-dataverse package is using a PR version, after IQSS/dataverse-client-javascript#296 is merged we need to update package version to use alpha.Suggestions on how to test this:
Step 1: Run the Development Environment
Step 2: Test the feature
email: [email protected]
pass: user
tou.htmlfile in your desktop with something like:<p>Be nice to each other</p>curl -X PUT http://localhost:8000/api/admin/settings/:ApplicationTermsOfUse --upload-file ~/Desktop/tou.htmland you should receive a response like:{"status":"OK","data":{":ApplicationTermsOfUse":"<p>Be nice to each other</p>\n"}}