Add tokenId denom conversion utils #688
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This was referenced Nov 24, 2025
swansontec
requested changes
Nov 25, 2025
Comment on lines
34
to
58
| export function getTokenMultiplier( | ||
| currencyInfo: EdgeCurrencyInfo, | ||
| allTokens: EdgeTokenMap, | ||
| tokenId: EdgeTokenId | ||
| ): string { | ||
| if (tokenId == null) { | ||
| for (const denomination of currencyInfo.denominations) { | ||
| if (denomination.name === currencyInfo.currencyCode) { | ||
| return denomination.multiplier | ||
| } | ||
| } | ||
| } else { | ||
| const token: EdgeToken | undefined = allTokens[tokenId] | ||
| if (token != null) { | ||
| for (const denomination of token.denominations) { | ||
| if (denomination.name === token.currencyCode) { | ||
| return denomination.multiplier | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| return '1' | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
The core should not provide utility functions like this, since everything goes over an expensive bridge. The denominationToNative and nativeToDenomination functions were historical accidents, and deprecation message says to "Use the information in EdgeCurrencyInfo / EdgeToken". We want to delete these guys, not replace them.
These types of utilities should move into edge-currency-accountbased and edge-react-gui in some sort of /utils file, since then they can be fast & synchronous.
…ols" This reverts commit ac53f48.
swansontec
approved these changes
Dec 3, 2025
Contributor
swansontec
left a comment
swansontec
left a comment
There was a problem hiding this comment.
The PR description is weird now (maybe edit that before merging), but the code is solid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
noneNote
Add optional
payoutTokenIdtoEdgeTxSwap, updating cleaners and tests accordingly.payoutTokenId?: EdgeTokenIdtoEdgeTxSwap(src/types/types.ts).asEdgeTokenIdand include optionalpayoutTokenIdinasEdgeTxSwap(src/core/currency/wallet/currency-wallet-cleaners.ts).payoutTokenId(test/fake/fake-transactions.ts,test/core/currency/wallet/currency-wallet.test.ts).payoutTokenIdtoEdgeTxSwap.Written by Cursor Bugbot for commit 9bc3e1b. This will update automatically on new commits. Configure here.