Skip to content

Conversation

@peachbits
Copy link
Contributor

@peachbits peachbits commented Nov 24, 2025

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

EdgeApp/edge-core-js#688

Description

none

Note

Replaces async wallet denomination calls with new synchronous helpers and migrates invalid-currency and same-asset logic to tokenId-based checks across swap plugins; bumps edge-core-js.

  • Utilities:
    • Introduce synchronous nativeToDenomination/denominationToNative in util/utils and use them throughout.
    • Replace checkInvalidCodes with checkInvalidTokenIds using tokenIds (incl. null for parents); update helpers in util/swapHelpers.
  • Centralized Plugins (changehero, changenow, exolix, godex, letsexchange, sideshift, swapuz):
    • Swap denomination conversions to new sync utils.
    • Use checkInvalidTokenIds; update invalid maps to tokenIds (e.g., Polygon USDC, VELO/MATH, Zcash null).
  • DeFi Plugins (lifi, rango, swapkit, thorchainCommon, cosmosIbc, xrpDex):
    • Migrate denomination conversions to sync utils.
    • Enforce tokenId-based same-asset checks; add payoutTokenId in Cosmos IBC; adjust ZEC handling to tokenId semantics.
  • Transfer Plugin: Compare fromTokenId/toTokenId for validation.
  • Tests: Update testpartner.ts to pass tokenIds and use new sync denomination helpers.
  • Dependencies: Bump edge-core-js to ^2.37.0.
  • Changelog: Add notes for sync denomination utils and tokenId-based invalid currency objects.

Written by Cursor Bugbot for commit b0e295c. This will update automatically on new commits. Configure here.


const quoteAmount =
request.quoteFor === 'from'
? await request.fromWallet.nativeToDenomination(
? await request.fromWallet.convertNativeToDenominated(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the core PR, we want to move these utilities into this repo, and then it would be nativeToDenomination(request.fromWallet, request.nativeAmount, request.fromTokenId)

@peachbits peachbits force-pushed the matthew/san-currency-code branch from 9749f42 to b0e295c Compare December 9, 2025 19:37
@peachbits peachbits merged commit 6bae3a5 into master Dec 9, 2025
2 checks passed
@peachbits peachbits deleted the matthew/san-currency-code branch December 9, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants