Skip to content

Conversation

@peachbits
Copy link
Contributor

@peachbits peachbits commented Nov 24, 2025

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

EdgeApp/edge-core-js#688

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Note

Replace currencyCode usage with tokenId across state, selectors, components, staking, loans, providers, and utils; update tests and bump edge-core-js to 2.36.0.

  • State & Selectors:
    • Replace selectedCurrencyCode with selectedTokenId in UI state and actions (UI/WALLETS/SELECT_WALLET, ACCOUNT_INIT_COMPLETE).
    • Remove selectDisplayDenomByCurrencyCode and getExchangeDenomByCurrencyCode; use selectDisplayDenom and getExchangeDenom(tokenId).
    • Change getCurrencyCodeMultiplier to accept tokenId (null for parent).
  • Actions & Reducers:
    • Update wallet selection, login initialization, activation flows, scan/sweep, staking state updates to use tokenId.
    • Adjust SettingsReducer and WalletsReducer payloads to carry tokenId.
  • Components:
    • Migrate send, swap, transaction, staking, FIO, loan, and provider UIs to tokenId (including AddressTile2, SwapDetailsCard, TransactionListTop, etc.).
    • Remove currencyCode-based assumptions in amount/fee displays and enablement.
  • Staking:
    • Expand stake types to include tokenId; update adapters/policies (Cardano, Coreum, Ethereum, Filecoin, Optimism/Tarot, Thorchain, Tron) and filtering logic.
    • Ensure token enablement via enableTokens and token-aware allocations/fees.
  • Loans:
    • Introduce LOAN_TOKEN_IDS; use enableTokens; remove currencyCode lookups; hard-code required tokenIds.
  • Providers/Plugins:
    • Update fiat/GUI providers and EdgeProvider server to compute amounts and tracking with tokenId.
    • CryptoAmount now requires tokenId (no currencyCode path).
  • Utilities:
    • Remove deprecated helpers (enableTokenCurrencyCode, currencyCode-based denomination lookups); update balance/fiat calcs to accept tokenId.
  • Tests & Locales:
    • Update tests to pass tokenId; snapshot reflects selectedTokenId.
    • Remove unused warning string.
  • Dependencies:
    • Bump edge-core-js to 2.36.0 (local file); lockfiles updated.

Written by Cursor Bugbot for commit 9ff151b. This will update automatically on new commits. Configure here.


plugin,
refundAddress
} = swapData
} = upgradeSwapData(wallet, swapData)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Wrong wallet passed to upgradeSwapData function

The upgradeSwapData function is called with wallet (the source wallet) instead of destinationWallet (the payout wallet). This causes the function to look up payoutTokenId or payoutCurrencyCode in the wrong wallet's currency configuration, potentially returning incorrect token information for the swap destination asset.

Fix in Cursor Fix in Web

"detect-bundler": "^1.1.0",
"disklet": "^0.5.2",
"edge-core-js": "^2.35.0",
"edge-core-js": "file:../edge-core-js",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Local file dependency in package.json

The edge-core-js dependency is changed to "file:../edge-core-js", which is a local file reference for development. This breaks the build for anyone without that specific directory structure and should not be committed to the repository. The dependency should reference a published version or a git URL instead.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants