Demo app foundations #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DemoApp will be created with JetpackCompose so that the basic dependencies will be added.
Composable functions start with uppercase, so Ktlint detects it as an error. Adding the exception for this case. "Function name should start with a lowercase letter (except factory methods) and use camel case (cannot be auto-corrected)" More configurations can be added using the .editoconfig file. See: https://pinterest.github.io/ktlint/latest/rules/configuration-ktlint/ and https://editorconfig.org/
The official ktlint doc also refers to this Compose ruleset |
maxme
approved these changes
Jan 18, 2024
| ) { | ||
| val colorScheme = | ||
| when { | ||
| dynamicColor && Build.VERSION.SDK_INT >= Build.VERSION_CODES.S -> { |
| modifier: Modifier = Modifier, | ||
| ) { | ||
| Text( | ||
| text = "Hello $name!", |
There was a problem hiding this comment.
Maybe I'm nitpicking because we'll likely remove this soon, but should we start with localized strings?
There was a problem hiding this comment.
I will delete it in the following PR, so it won't last long. But yeah, the following strings should be localized.
There was a problem hiding this comment.
@hamorillo BTW, do we have a rule to check for unlocalizable strings?
In fact, I've found the Twitter repo because Compose ruleset is a fork of it. 😅 |
|
❤️ Thanks for the review @maxme! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating the DemoApp foundations. As we've decided to use Jetcpack Compose adding also the basic dependencies.
Note: Composable functions start with uppercase, so Ktlint detects them as an error. I'm adding the exception for this case in the
.editorconfig.Without the exception, you'll receive the following lint error:
I saw that Twitter has a repo with more rules; just commenting on it here for future reference.
Testing
Hello Android!😅)