DemoApp - First interation #42
Conversation
Using the Gravatar library to generate the GravatarUrl that we use to load the image.
hamorillo
changed the title
| } | ||
|
|
||
| @Composable | ||
| fun GravatarImage(gravatarUrl: String) = AsyncImage(model = gravatarUrl, contentDescription = null) |
There was a problem hiding this comment.
I think we should go ahead and log something onError here. This might be useful for testing.
And I wonder if we should show something specific when we get a 404 (eg. with the "Default avatar: 404" selected)
There was a problem hiding this comment.
I agree; I've created a new ticket, #44, to create a PR with the error handling.
| fun GravatarImageSettingsPreview() { | ||
| GravatarDemoAppTheme { | ||
| GravatarImageSettings( | ||
| email = "[email protected]", |
There was a problem hiding this comment.
Can we use a test email that has a gravatar image? This will simplify testing. There must be some demo account, if not we should create some.
There was a problem hiding this comment.
Using [email protected] now. It was mentioned here.
| Column( | ||
| modifier = Modifier | ||
| .fillMaxSize() | ||
| .background(MaterialTheme.colorScheme.background) |
There was a problem hiding this comment.
We must use dynamic colors for other components as well if we want to keep this readable in dark mode.
There was a problem hiding this comment.
Great catch! Thanks!
Added a surface to fix Text color issues.
| onEmailChanged = { email = it }, | ||
| onSizeChange = { avatarSize = it }, | ||
| onLoadGravatarClicked = { | ||
| gravatarUrl = emailAddressToGravatarUrl( |
There was a problem hiding this comment.
I wonder if we should:
- catch the illegal argument exceptions here
- limit the size input to be between 1..2048 in the text field component
- or sanitize size input in the text field component
There was a problem hiding this comment.
Given this is a demo/test app, I think we should go with the first one and show the error in the UI. I'll work on this in #44.
❤️ Great suggestions!
Adding a surface as a parent composable makes the inside composables use the surface color when needed.
#26
This PR is the iteration to create a DemoApp that uses the GravatarUtils we support in the SDK. The app allows you to introduce an e-mail for loading its' corresponding GravatarImageUrl.
In addition, you can play with the params "Default Avatar Image" and "Avatar Size".
Next Steps: Include the rest of the possible parameters and polish the app.
Kapture.2024-01-26.at.12.52.27.mp4