Debug e2e not failing for ConfigMap feature #557
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katyanna
force-pushed
the
config-rsc-e2e
branch
from
3db9342 to
46d5293
Compare
Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
This reverts commit b409913.
katyanna
force-pushed
the
config-map-e2e
branch
from
224d3e5 to
095758d
Compare
linki
force-pushed
the
config-rsc-e2e
branch
from
0c033af to
c59e59a
Compare
|
This now fails the e2e tests for the right reasons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed in the context of #495 that removing this code did not fail the e2e, which was a surprise.
@gargravarr pointed out the feature is not enabled in e2e:
stackset-controller/e2e/apply/deployment.yaml
Lines 25 to 30 in 83ce20f