Add e2e tests for ConfigMap feature

[katyanna]

Debug e2e not failing for ConfigMap feature

[linki]

👍

[mikkeloscar]

@linki I was thinking it could make sense to have a test showing the behavior when it fails e.g. the configmap is not there.

Basically traffic switching should not succeed if configmap is missing.

You could be inspired by this test:

stackset-controller/cmd/e2e/broken_stack_test.go

Lines 13 to 53 in 4278725

	func TestBrokenStacks(t *testing.T) {
	t.Parallel()
	stacksetName := "stackset-broken-stacks"
	factory := NewTestStacksetSpecFactory(stacksetName).Ingress().StackGC(1, 30)
	firstVersion := "v1"
	firstStack := fmt.Sprintf("%s-%s", stacksetName, firstVersion)
	spec := factory.Create(firstVersion)
	err := createStackSet(stacksetName, 0, spec)
	require.NoError(t, err)
	_, err = waitForStack(t, stacksetName, firstVersion)
	require.NoError(t, err)
	unhealthyVersion := "v2"
	unhealthyStack := fmt.Sprintf("%s-%s", stacksetName, unhealthyVersion)
	spec = factory.Create(unhealthyVersion)
	spec.StackTemplate.Spec.Service.Ports = []corev1.ServicePort{
	{
	Protocol: corev1.ProtocolTCP,
	TargetPort: intstr.FromString("foobar"),
	},
	}
	err = updateStackset(stacksetName, spec)
	require.NoError(t, err)
	_, err = waitForStack(t, stacksetName, unhealthyVersion)
	require.NoError(t, err)
	_, err = waitForIngress(t, stacksetName)
	require.NoError(t, err)
	initialWeights := map[string]float64{firstStack: 100}
	err = trafficWeightsUpdatedStackset(t, stacksetName, weightKindActual, initialWeights, nil).await()
	require.NoError(t, err)
	// Switch traffic to the second stack, this should fail
	desiredWeights := map[string]float64{unhealthyStack: 100}
	err = setDesiredTrafficWeightsStackset(stacksetName, desiredWeights)
	require.NoError(t, err)
	err = trafficWeightsUpdatedStackset(t, stacksetName, weightKindActual, desiredWeights, nil).await()
	require.Error(t, err)

[linki]

This stuff makes sure that if you configure your Stackset to have a versioned ConfigMap (via the factory and calling ConfigMap()) that it will end up with a working configuration (name pattern matches, external ConfigMap exists).

[linki]

👍

[katyanna]

👍