Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typescript build #63

Merged
merged 2 commits into from
Aug 27, 2024
Merged

fix: typescript build #63

merged 2 commits into from
Aug 27, 2024

Conversation

tpoisseau
Copy link
Member

No description provided.

@tpoisseau tpoisseau linked an issue Aug 27, 2024 that may be closed by this pull request
@tpoisseau tpoisseau marked this pull request as ready for review August 27, 2024 12:08
@tpoisseau tpoisseau requested a review from targos August 27, 2024 12:08
@tpoisseau
Copy link
Member Author

tpoisseau commented Aug 27, 2024

First solution was to pin typescript to 5.4.5 (hotfix).
Second solution, for long term fix: pin typescript to 5.5.4 and tweak index.ts so it do not rely on /// <reference.

I think pin typescript is important in a lib (no package-lock.json) because typescript is known to not follow semver rules, silent updates are risky.

import module declaration seems work

I tried this version locally in ProFID with `npm pack`.
Set the dependency to absolute path of pack.
`npm install` and no typescript module resolution errors.
@tpoisseau tpoisseau force-pushed the 62-indexdts-is-missing-in-build branch from aa195ad to 71f85f0 Compare August 27, 2024 12:22
@targos targos changed the title fix: set typescript version so the build contain filled index.d.ts fix: typescript build Aug 27, 2024
@targos targos merged commit fb69c00 into main Aug 27, 2024
7 checks passed
@targos targos deleted the 62-indexdts-is-missing-in-build branch August 27, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

index.d.ts is missing in build
2 participants