Convert envelope trait to abstract class #231
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
samdark
approved these changes
Feb 14, 2025
xepozz
requested changes
Feb 15, 2025
| { | ||
| return []; | ||
| } | ||
| abstract protected function getEnvelopeMetadata(): array; |
There was a problem hiding this comment.
it's good to keep default empty array
| @@ -37,12 +37,4 @@ public function getMetadata(): array | |||
| { | |||
| return $this->metadata; | |||
| } | |||
|
|
|||
| public function withMetadata(array $metadata): self | |||
| private MessageInterface $message, | ||
| private array $meta = [], | ||
| MessageInterface $message, | ||
| private readonly array $failureMeta = [], |
There was a problem hiding this comment.
Suggested change
| private readonly array $failureMeta = [], | |
| private readonly array $metadata = [], |
| @@ -23,14 +20,6 @@ public function getMessage(): MessageInterface | |||
| return $this->message; | |||
| } | |||
|
|
|||
| public function withMessage(MessageInterface $message): self | |||
| $meta[self::FAILURE_META_KEY] = array_merge($meta[self::FAILURE_META_KEY] ?? [], $this->meta); | ||
|
|
||
| return $meta; | ||
| return [self::FAILURE_META_KEY => ArrayHelper::merge($this->message->getMetadata()[self::FAILURE_META_KEY] ?? [], $this->failureMeta)]; |
There was a problem hiding this comment.
as you can see getEnvelopeMetadata method must provide all the collected metadata, not only the owned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.