Skip to content

Conversation

@viktorprogger
Copy link
Contributor

Q A
Is bugfix?
New feature?
Breaks BC?

This PR simplifies the Envelope concept. The main changes are:

  • EnvelopeTrait is converted into AbstractEnvelope class.
  • If an envelope uses the new abstract class, there is no more envelope stack, which requires recursive data search. There is always a single envelope around a message.

With these changes it's dimpler to debug an application with envelopes. It's also becomes simple and meaningful to use unique method of envelopes be envelope creation in place like this, because there is no more a deep envelope stack with a recursive data search:

$id = IdEnvelope::fromMessage($message)->getId();

@viktorprogger viktorprogger self-assigned this Sep 20, 2024
@viktorprogger viktorprogger requested review from a team, samdark and xepozz September 20, 2024 13:48
@viktorprogger viktorprogger added the status:code review The pull request needs review. label Sep 20, 2024
@yiisoft yiisoft deleted a comment from samdark Nov 10, 2024
@viktorprogger
Copy link
Contributor Author

Trait to abstract class conversion is moved to #231, other changes slow down this package too much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants