Skip to content

* Added validation of WithTxControl option in non-interactive methods… #1738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

rekby
Copy link
Member

@rekby rekby commented Apr 23, 2025

… of Client and Session

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

Copy link

summary

Base version: v3.108.0 (master)
Suggested version: v3.108.1

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 45.16129% with 34 lines in your changes missing coverage. Please review.

Project coverage is 68.89%. Comparing base (4ebb2e4) to head (8d2094e).

Files with missing lines Patch % Lines
internal/query/client.go 18.18% 12 Missing and 6 partials ⚠️
internal/query/session.go 11.11% 14 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1738      +/-   ##
==========================================
- Coverage   71.19%   68.89%   -2.30%     
==========================================
  Files         383      384       +1     
  Lines       39140    39200      +60     
==========================================
- Hits        27864    27006     -858     
- Misses      10151    11048     +897     
- Partials     1125     1146      +21     
Flag Coverage Δ
experiment ?
go-1.21.x 70.85% <45.16%> (-0.23%) ⬇️
go-1.24.x 68.86% <45.16%> (-2.28%) ⬇️
integration 53.48% <33.87%> (-0.52%) ⬇️
macOS 38.28% <35.48%> (-0.03%) ⬇️
ubuntu 68.87% <45.16%> (-2.31%) ⬇️
unit 38.29% <35.48%> (-0.03%) ⬇️
windows 38.27% <35.48%> (-0.05%) ⬇️
ydb-24.1 51.31% <33.87%> (-0.34%) ⬇️
ydb-24.2 51.32% <33.87%> (-0.49%) ⬇️
ydb-24.3 51.69% <33.87%> (-0.54%) ⬇️
ydb-24.4 51.52% <33.87%> (-0.71%) ⬇️
ydb-25.1 53.31% <33.87%> (-0.54%) ⬇️
ydb-nightly ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rekby rekby force-pushed the issue-1737-deny-uncommitted-noninteractive branch from 3f3d26d to 813e20e Compare April 24, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants