Better detect nil value under interface

Author: rekby

internal/query/client.go

@@ -21,6 +21,7 @@ import (
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/types"
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/xcontext"
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/xerrors"
+	"github.com/ydb-platform/ydb-go-sdk/v3/internal/xreflect"
 	"github.com/ydb-platform/ydb-go-sdk/v3/query"
 	"github.com/ydb-platform/ydb-go-sdk/v3/retry"
 	"github.com/ydb-platform/ydb-go-sdk/v3/trace"
@@ -641,9 +642,10 @@ func New(ctx context.Context, cc grpc.ClientConnInterface, cfg *config.Config) *
 
 // checkTxControlWithCommit checks that if WithTxControl is used, it must be with WithCommit
 func checkTxControlWithCommit(txControl options.TxControl) error {
-	if txControl != nil && !txControl.Commit() {
+	if !xreflect.IsPointToNil(txControl) && !txControl.Commit() {
 		return xerrors.WithStackTrace(errNoCommit)
 	}
+	
 	return nil
 }
 

internal/xreflect/is_nil.go

@@ -0,0 +1,31 @@
+package xreflect
+
+import "reflect"
+
+func IsPointToNil(v any) bool {
+	if v == nil {
+		return true
+	}
+
+	rVal := reflect.ValueOf(v)
+
+	return isValPointToNil(rVal)
+}
+
+func isValPointToNil(v reflect.Value) bool {
+	kind := v.Kind()
+	var res bool
+	switch kind {
+	case reflect.Slice:
+		return false
+	case reflect.Chan, reflect.Func, reflect.Map, reflect.UnsafePointer:
+		res = v.IsNil()
+	case reflect.Pointer, reflect.Interface:
+		elem := v.Elem()
+		if v.IsNil() {
+			return true
+		}
+		res = isValPointToNil(elem)
+	}
+	return res
+}

internal/xreflect/is_nil_test.go

@@ -0,0 +1,93 @@
+package xreflect
+
+import (
+	"testing"
+)
+
+func TestPointToNilValue(t *testing.T) {
+	var nilIntPointer *int
+	var vInterface any
+	vInterface = nilIntPointer
+
+	// Test cases for different nil and non-nil scenarios
+	tests := []struct {
+		name     string
+		input    any
+		expected bool
+	}{
+		{
+			name:     "nil interface",
+			input:    nil,
+			expected: true,
+		},
+		{
+			name:     "nil pointer to int",
+			input:    (*int)(nil),
+			expected: true,
+		},
+		{
+			name:     "non-nil pointer to int",
+			input:    new(int),
+			expected: false,
+		},
+		{
+			name:     "nil slice",
+			input:    []int(nil),
+			expected: false,
+		},
+		{
+			name:     "empty slice",
+			input:    []int{},
+			expected: false,
+		},
+		{
+			name:     "nil map",
+			input:    map[string]int(nil),
+			expected: true,
+		},
+		{
+			name:     "empty map",
+			input:    map[string]int{},
+			expected: false,
+		},
+		{
+			name:     "nil channel",
+			input:    (chan int)(nil),
+			expected: true,
+		},
+		{
+			name:     "non-nil channel",
+			input:    make(chan int),
+			expected: false,
+		},
+		{
+			name:     "nil function",
+			input:    (func())(nil),
+			expected: true,
+		},
+		{
+			name:     "nested nil pointer",
+			input:    &nilIntPointer,
+			expected: true,
+		},
+		{
+			name:     "interface with stored nil pointer",
+			input:    vInterface,
+			expected: true,
+		},
+		{
+			name:     "non-nil interface value",
+			input:    interface{}("test"),
+			expected: false,
+		},
+	}
+
+	// Execute all test cases
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			if got := IsPointToNil(tt.input); got != tt.expected {
+				t.Errorf("IsPointToNil() = %v, want %v", got, tt.expected)
+			}
+		})
+	}
+}