Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Pin Node.js version when using mise-en-place #681

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Misc] Pin Node.js version when using mise-en-place #681

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions mise.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[tools]
node = "22.13.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of seeing the node version duplicated between this file and the root package.json
Would it be possible to point this config file to the package.json definition?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, apparently this is no-fix for mise: jdx/mise#2284
Nvm does the same actually: nvm-sh/nvm#651

The field in package.json indicates the compatibility, not the final Node.js version to use. It's only an indicator of which version is compatible. So I think it makes sense to have the actual version in a separate file, though I can also understand if having a "duplicate" is a problem.