[Misc] Pin Node.js version when using mise-en-place #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelleduc
reviewed
Feb 19, 2025
| @@ -0,0 +1,2 @@ | |||
| [tools] | |||
| node = "22.13.1" | |||
There was a problem hiding this comment.
I'm not a fan of seeing the node version duplicated between this file and the root package.json
Would it be possible to point this config file to the package.json definition?
There was a problem hiding this comment.
Good point, apparently this is no-fix for mise: jdx/mise#2284
Nvm does the same actually: nvm-sh/nvm#651
The field in package.json indicates the compatibility, not the final Node.js version to use. It's only an indicator of which version is compatible. So I think it makes sense to have the actual version in a separate file, though I can also understand if having a "duplicate" is a problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
N/A
Changes
Description
Clarifications
Screenshots & Video
N/A
Executed Tests
N/A
Expected merging strategy
cc @manuelleduc