Skip to content

Add oauth_credentials to AuthenticationResponse #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
salbito-workos wants to merge 2 commits into from
Closed

Add oauth_credentials to AuthenticationResponse #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdc08c1
Add oauth_credentials to AuthenticationResponse
salbito-workos Nov 4, 2024
29e4df2
Add OauthCredentialProviders
salbito-workos Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion workos/types/user_management/authentication_response.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
from typing import Literal, Optional, TypeVar

from workos.types.user_management.impersonator import Impersonator
from workos.types.user_management.oauth_credentials import OauthCredentials
from workos.types.user_management.user import User
from workos.types.workos_model import WorkOSModel


AuthenticationMethod = Literal[
"SSO",
"Password",
Expand All @@ -27,6 +28,7 @@ class AuthenticationResponse(_AuthenticationResponseBase):
authentication_method: Optional[AuthenticationMethod] = None
impersonator: Optional[Impersonator] = None
organization_id: Optional[str] = None
oauth_credentials: Optional[OauthCredentials] = None
Copy link
Contributor

@mattgd mattgd Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will OAuth credentials exist for all authentication methods or just authenticate with code?

user: User


Expand Down
19 changes: 19 additions & 0 deletions workos/types/user_management/oauth_credentials.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
from typing import Literal, List
from workos.types.workos_model import WorkOSModel

OauthCredentialProviders = Literal[
Copy link
Contributor

@mattgd mattgd Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nit naming suggestion for type

Suggested change
OauthCredentialProviders = Literal[
OauthCredentialProviderType = Literal[

"AppleOauth",
"GitHubOauth",
"GoogleOauth",
"MicrosoftOauth",
]


class OauthCredentials(WorkOSModel):
"""Representation of a Oauth credentials"""

provider: OauthCredentialProviders
access_token: str
refresh_token: str
expires_at: int
scopes: List[str]
Loading