Add oauth_credentials to AuthenticationResponse #377
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattgd
reviewed
Nov 4, 2024
| authentication_method: Optional[AuthenticationMethod] = None | ||
| impersonator: Optional[Impersonator] = None | ||
| organization_id: Optional[str] = None | ||
| oauth_credentials: Optional[OauthCredentials] = None |
Contributor
There was a problem hiding this comment.
Will OAuth credentials exist for all authentication methods or just authenticate with code?
mattgd
reviewed
Nov 4, 2024
| from typing import Literal, List | ||
| from workos.types.workos_model import WorkOSModel | ||
|
|
||
| OauthCredentialProviders = Literal[ |
Contributor
There was a problem hiding this comment.
Very nit naming suggestion for type
Suggested change
| OauthCredentialProviders = Literal[ | |
| OauthCredentialProviderType = Literal[ |
Contributor
Author
|
Closing for now as the underlying api will be changing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changeset adds oauth_credentials to the AuthenticationResponse model.
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.