Skip to content

chore: default list methods to descending order #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions .semaphore/semaphore.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,31 +3,21 @@ name: Python
agent:
machine:
type: e1-standard-2
os_image: ubuntu1804
containers:
- name: main
image: "registry.semaphoreci.com/python:3.7"
blocks:
- task:
secrets:
- name: codecov-workos-python
prologue:
commands:
- checkout
- sem-version python 2.7
- python -m pip install --upgrade pip
- pip install -e .[dev]
- sem-version python 3.7
- python -m pip install --upgrade pip
- pip install -e .[dev]
jobs:
- name: python
commands:
- sem-version python 2.7
- flake8 . --count --select=E9,F7,F82 --show-source --statistics
- flake8 . --count --exit-zero --max-complexity=10 --statistics
- pytest
# Coverage would be the same regardless of Python version
- name: python3 + codecov
commands:
- sem-version python 3.7
- flake8 . --count --select=E9,F7,F82 --show-source --statistics
- flake8 . --count --exit-zero --max-complexity=10 --statistics
- pytest --cov-report xml --cov=workos
Expand Down
2 changes: 1 addition & 1 deletion workos/__about__.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

__package_url__ = "https://github.com/workos-inc/workos-python"

__version__ = "2.2.0"
__version__ = "3.0.0"

__author__ = "WorkOS"

Expand Down
22 changes: 16 additions & 6 deletions workos/directory_sync.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def list_users(
"limit": limit,
"before": before,
"after": after,
"order": order,
"order": order or "desc",
}

if group is not None:
Expand Down Expand Up @@ -138,7 +138,7 @@ def list_users_v2(
"limit": limit,
"before": before,
"after": after,
"order": order,
"order": order or "desc",
}

if group is not None:
Expand Down Expand Up @@ -206,7 +206,12 @@ def list_groups(
limit = RESPONSE_LIMIT
default_limit = True

params = {"limit": limit, "before": before, "after": after, "order": order}
params = {
"limit": limit,
"before": before,
"after": after,
"order": order or "desc",
}
if user is not None:
params["user"] = user
if directory is not None:
Expand Down Expand Up @@ -268,7 +273,12 @@ def list_groups_v2(
limit = RESPONSE_LIMIT
default_limit = True

params = {"limit": limit, "before": before, "after": after, "order": order}
params = {
"limit": limit,
"before": before,
"after": after,
"order": order or "desc",
}
if user is not None:
params["user"] = user
if directory is not None:
Expand Down Expand Up @@ -395,7 +405,7 @@ def list_directories(
"limit": limit,
"before": before,
"after": after,
"order": order,
"order": order or "desc",
}

if order is not None:
Expand Down Expand Up @@ -463,7 +473,7 @@ def list_directories_v2(
"limit": limit,
"before": before,
"after": after,
"order": order,
"order": order or "desc",
}

if order is not None:
Expand Down
4 changes: 2 additions & 2 deletions workos/organizations.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def list_organizations(
"limit": limit,
"before": before,
"after": after,
"order": order,
"order": order or "desc",
}

if order is not None:
Expand Down Expand Up @@ -122,7 +122,7 @@ def list_organizations_v2(
"limit": limit,
"before": before,
"after": after,
"order": order,
"order": order or "desc",
}

if order is not None:
Expand Down
2 changes: 1 addition & 1 deletion workos/resources/list.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def auto_paging_iter(self):
params = {
"after": after,
"before": before,
"order": order,
"order": order or "desc",
}
params.update(resource_specific_params)

Expand Down
4 changes: 2 additions & 2 deletions workos/sso.py
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ def list_connections(
"limit": limit,
"before": before,
"after": after,
"order": order,
"order": order or "desc",
}

if order is not None:
Expand Down Expand Up @@ -317,7 +317,7 @@ def list_connections_v2(
"limit": limit,
"before": before,
"after": after,
"order": order,
"order": order or "desc",
}

if order is not None:
Expand Down
3 changes: 3 additions & 0 deletions workos/user_management.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ def list_users(
"limit": limit,
"before": before,
"after": after,
"order": order or "desc",
}

if order is not None:
Expand Down Expand Up @@ -278,6 +279,7 @@ def list_organization_memberships(
"limit": limit,
"before": before,
"after": after,
"order": order or "desc",
}

if order is not None:
Expand Down Expand Up @@ -944,6 +946,7 @@ def list_invitations(
"limit": limit,
"before": before,
"after": after,
"order": order or "desc",
}

if order is not None:
Expand Down