Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: default list methods to descending order #234

Merged
merged 11 commits into from
Mar 8, 2024
Merged

Conversation

faroceann
Copy link
Contributor

@faroceann faroceann commented Mar 5, 2024

Description

  • Default list methods to descending order.
  • Remove tests on python v2

Documentation

Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.

[ ] Yes

If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.

@faroceann faroceann requested a review from a team as a code owner March 5, 2024 19:31
@faroceann faroceann requested a review from PavanKulkarni March 5, 2024 19:31
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.89%. Comparing base (a66a738) to head (bcd62ef).

Files Patch % Lines
workos/directory_sync.py 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #234   +/-   ##
=======================================
  Coverage   85.89%   85.89%           
=======================================
  Files          31       31           
  Lines        1234     1234           
=======================================
  Hits         1060     1060           
  Misses        174      174           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@faroceann faroceann merged commit e65ec1e into main Mar 8, 2024
10 checks passed
@faroceann faroceann deleted the list-defaults branch March 8, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants