Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JetpackStatsWidget #24222

Merged
merged 3 commits into from
Mar 19, 2025
Merged

Update JetpackStatsWidget #24222

merged 3 commits into from
Mar 19, 2025

Conversation

kean
Copy link
Contributor

@kean kean commented Mar 14, 2025 •
edited
Loading

This is the second part of bringing the JetpackStatsWidget into a world with no files shared across targets.

  • Move HomeWidgetCache to JetpackStatsWidgetsCore
  • Remove JetpackStatsWidgets-Bridging-Header.h
  • Remove Constants.m, AppConfiguration.swift, ExtensionConfiguration.swift, CocoaLumberjack.swift, etc from JetpackStatsWidget
  • Remove duplicated and unused now AppConfigurarion.Widget extension
  • Remove AppConfiguration.Widget.Localization

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the General label Mar 14, 2025
@kean kean added this to the 25.9 milestone Mar 14, 2025
kean
kean commented Mar 14, 2025
View reviewed changes
WordPress/JetpackStatsWidgets/Model/HomeWidgetData.swift

let cache = cache ?? HomeWidgetCache<Self>(fileName: Self.filename,
appGroup: BuildSettings.appGroupName)
let cache = cache ?? makeCache()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated this for simplicity. It's just convenience wrappers – I don't think it hurts. It's better than creating yet another module just to reuse two methods.

@dangermattic
Copy link
Collaborator

dangermattic commented Mar 14, 2025 •
edited
Loading

2 Warnings
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is assigned to the milestone 25.9. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@kean kean enabled auto-merge March 14, 2025 21:15
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 14, 2025 •
edited
Loading

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr24222-69fb90c
Version25.8
Bundle IDcom.jetpack.alpha
Commit69fb90c
App Center Buildjetpack-installable-builds #10758
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 14, 2025 •
edited
Loading

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr24222-69fb90c
Version25.8
Bundle IDorg.wordpress.alpha
Commit69fb90c
App Center BuildWPiOS - One-Offs #11730
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean requested review from mokagio and jkmassel March 14, 2025 21:41
@kean kean mentioned this pull request Mar 14, 2025
Merged
14 tasks
@kean kean force-pushed the task/rework-stats-widget-p2 branch 2 times, most recently from 4f6a651 to 6674758 Compare March 18, 2025 15:14
@kean kean marked this pull request as draft March 18, 2025 15:14
auto-merge was automatically disabled March 18, 2025 15:14

Pull request was converted to draft

@kean kean removed request for jkmassel and mokagio March 18, 2025 15:14
@kean kean force-pushed the task/rework-stats-widget-p2 branch 3 times, most recently from 854a6e2 to a9fbce5 Compare March 18, 2025 17:41
@kean kean changed the title Rework JetpackStatsWidget (Part 2) Update JetpackStatsWidget Mar 18, 2025
@kean kean force-pushed the task/rework-stats-widget-p2 branch from a9fbce5 to c9694b0 Compare March 18, 2025 17:43
@kean
Copy link
Contributor Author

kean commented Mar 18, 2025

I updated it with the latest changes, so it's now ready for review.

@kean kean marked this pull request as ready for review March 18, 2025 17:43
@kean kean requested review from jkmassel, mokagio and crazytonyli and removed request for jkmassel March 18, 2025 17:43
@kean kean enabled auto-merge March 19, 2025 11:59
@kean kean added this pull request to the merge queue Mar 19, 2025
Merged via the queue into trunk with commit a05719d Mar 19, 2025
25 checks passed
@kean kean deleted the task/rework-stats-widget-p2 branch March 19, 2025 13:03
@kean kean mentioned this pull request Mar 19, 2025
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazytonyli crazytonyli crazytonyli approved these changes

@mokagio mokagio Awaiting requested review from mokagio

Assignees
No one assigned
Labels
General
Projects
None yet
Milestone
25.9
Development

Successfully merging this pull request may close these issues.
4 participants
@kean @dangermattic @wpmobilebot @crazytonyli