Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract TracksMini #24255

Merged
merged 4 commits into from
Mar 19, 2025
Merged

Extract TracksMini #24255

merged 4 commits into from
Mar 19, 2025

Conversation

kean
Copy link
Contributor

@kean kean commented Mar 19, 2025

Follow-up for #24222. This PR removes the last remaining files in JetpackStatsWidgets target that were included in multiple targets.

  • Remove AppStyleGuide, BuildConfiguration from JetpackStatsWidget (unused now)
  • Add default Tracks appGroupName parameter
  • Move Tracks to a new TracksMini module – this is a "mini" version of Tracks used across app extensions. I'm not sure why we aren't using a full-blown version, but changing it isn't in the scope of the project.

To test: n/a (moving code, no functional changes)

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the General label Mar 19, 2025
@kean kean added this to the 25.9 milestone Mar 19, 2025
@kean kean requested review from mokagio and pmusolino March 19, 2025 15:01
@kean kean enabled auto-merge March 19, 2025 15:09
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr24255-bf74f98
Version25.8
Bundle IDorg.wordpress.alpha
Commitbf74f98
App Center BuildWPiOS - One-Offs #11732
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr24255-bf74f98
Version25.8
Bundle IDcom.jetpack.alpha
Commitbf74f98
App Center Buildjetpack-installable-builds #10760
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@dangermattic
Copy link
Collaborator

2 Warnings
⚠️ Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).
⚠️ This PR is assigned to the milestone 25.9. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@pmusolino pmusolino self-assigned this Mar 19, 2025
Copy link
Member

@pmusolino pmusolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kean kean added this pull request to the merge queue Mar 19, 2025
Merged via the queue into trunk with commit 36a1509 Mar 19, 2025
27 checks passed
@kean kean deleted the task/finalize-stats-widget branch March 19, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants