-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract TracksMini #24255
Merged
Merged
Extract TracksMini #24255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr24255-bf74f98 | |
Version | 25.8 | |
Bundle ID | org.wordpress.alpha | |
Commit | bf74f98 | |
App Center Build | WPiOS - One-Offs #11732 |
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr24255-bf74f98 | |
Version | 25.8 | |
Bundle ID | com.jetpack.alpha | |
Commit | bf74f98 | |
App Center Build | jetpack-installable-builds #10760 |
Generated by 🚫 Danger |
pmusolino
approved these changes
Mar 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #24222. This PR removes the last remaining files in
JetpackStatsWidgets
target that were included in multiple targets.AppStyleGuide
,BuildConfiguration
fromJetpackStatsWidget
(unused now)Tracks
appGroupName
parameterTracks
to a newTracksMini
module – this is a "mini" version of Tracks used across app extensions. I'm not sure why we aren't using a full-blown version, but changing it isn't in the scope of the project.To test: n/a (moving code, no functional changes)
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: