Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert WordPressData from Swift package to Xcode target #24194

Closed
wants to merge 8 commits into from
Closed
15 changes: 5 additions & 10 deletions Modules/Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ let package = Package(
.library(name: "DesignSystem", targets: ["DesignSystem"]),
.library(name: "JetpackStatsWidgetsCore", targets: ["JetpackStatsWidgetsCore"]),
.library(name: "SFHFKeychainUtils", targets: ["SFHFKeychainUtils"]),
.library(name: "WordPressData", targets: ["WordPressData"]),
.library(name: "WordPressFlux", targets: ["WordPressFlux"]),
.library(name: "WordPressShared", targets: ["WordPressShared"]),
.library(name: "WordPressUI", targets: ["WordPressUI"]),
Expand Down Expand Up @@ -71,14 +70,6 @@ let package = Package(
.product(name: "ScreenObject", package: "ScreenObject"),
.product(name: "XCUITestHelpers", package: "ScreenObject"),
], swiftSettings: [.swiftLanguageMode(.v5)]),
.target(name: "WordPressDataObjC"),
.target(
name: "WordPressData",
dependencies: [
.target(name: "WordPressDataObjC"),
.target(name: "WordPressSharedObjC")
]
),
.target(name: "WordPressFlux", swiftSettings: [.swiftLanguageMode(.v5)]),
.target(name: "WordPressCore", dependencies: [.target(name: "WordPressShared"), .product(name: "WordPressAPI", package: "wordpress-rs")]),
.target(name: "WordPressSharedObjC", resources: [.process("Resources")], swiftSettings: [.swiftLanguageMode(.v5)]),
Expand Down Expand Up @@ -131,6 +122,7 @@ enum XcodeSupport {
.library(name: "XcodeTarget_WordPressTests", targets: ["XcodeTarget_WordPressTests"]),
.library(name: "XcodeTarget_WordPressAuthentificator", targets: ["XcodeTarget_WordPressAuthentificator"]),
.library(name: "XcodeTarget_WordPressAuthentificatorTests", targets: ["XcodeTarget_WordPressAuthentificatorTests"]),
.library(name: "XcodeTarget_WordPressData", targets: ["XcodeTarget_WordPressData"]),
.library(name: "XcodeTarget_ShareExtension", targets: ["XcodeTarget_ShareExtension"]),
.library(name: "XcodeTarget_DraftActionExtension", targets: ["XcodeTarget_DraftActionExtension"]),
.library(name: "XcodeTarget_NotificationServiceExtension", targets: ["XcodeTarget_NotificationServiceExtension"]),
Expand Down Expand Up @@ -177,7 +169,6 @@ enum XcodeSupport {
"DesignSystem",
"JetpackStatsWidgetsCore",
"SFHFKeychainUtils",
"WordPressData",
"WordPressFlux",
"WordPressShared",
"WordPressReader",
Expand Down Expand Up @@ -223,6 +214,10 @@ enum XcodeSupport {
]),
.xcodeTarget("XcodeTarget_WordPressAuthentificator", dependencies: wordPresAuthentificatorDependencies),
.xcodeTarget("XcodeTarget_WordPressAuthentificatorTests", dependencies: wordPresAuthentificatorDependencies + testDependencies),
.xcodeTarget(
"XcodeTarget_WordPressData",
dependencies: ["WordPressShared"]
),
.xcodeTarget("XcodeTarget_ShareExtension", dependencies: shareAndDraftExtensionsDependencies),
.xcodeTarget("XcodeTarget_DraftActionExtension", dependencies: shareAndDraftExtensionsDependencies),
.xcodeTarget("XcodeTarget_NotificationServiceExtension", dependencies: [
Expand Down
1 change: 0 additions & 1 deletion Modules/Sources/WordPressData/WordPressData.swift

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import Foundation

public struct __Empty {}
2 changes: 1 addition & 1 deletion WordPress/Classes/Categories/Media+Extensions.m
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#import "Media+Extensions.h"
#import "MediaService.h"
#import "Blog.h"
@import WordPressDataObjC;
@import WordPressData;
#import "WordPress-Swift.h"

@implementation Media (Extensions)
Expand Down
2 changes: 1 addition & 1 deletion WordPress/Classes/Models/AbstractPost.m
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#import "AbstractPost.h"
#import "Media.h"
@import WordPressDataObjC;
@import WordPressData;
#import "WordPress-Swift.h"
#import "BasePost.h"

Expand Down
2 changes: 1 addition & 1 deletion WordPress/Classes/Models/BasePost.m
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#import "BasePost.h"
#import "Media.h"
@import WordPressDataObjC;
@import WordPressData;

@import WordPressShared;

Expand Down
2 changes: 1 addition & 1 deletion WordPress/Classes/Models/Blog/Blog.m
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#import "Blog.h"
#import "WPAccount.h"
#import "AccountService.h"
@import WordPressDataObjC;
@import WordPressData;
#import "WPUserAgent.h"
#import "WordPress-Swift.h"
@import SFHFKeychainUtils;
Expand Down
2 changes: 1 addition & 1 deletion WordPress/Classes/Models/Media.m
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#import "Media.h"
@import WordPressDataObjC;
@import WordPressData;
#import "WordPress-Swift.h"

@implementation Media
Expand Down
2 changes: 1 addition & 1 deletion WordPress/Classes/Models/ReaderPost.m
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#import "ReaderPost.h"
#import "AccountService.h"
@import WordPressDataObjC;
@import WordPressData;
#import "SourcePostAttribution.h"
#import "WPAccount.h"
#import "WordPress-Swift.h"
Expand Down
2 changes: 1 addition & 1 deletion WordPress/Classes/Models/Theme.m
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#import "Theme.h"
#import "Blog.h"
@import WordPressDataObjC;
@import WordPressData;
#import "WPAccount.h"
#import "AccountService.h"
#import "WordPress-Swift.h"
Expand Down
2 changes: 1 addition & 1 deletion WordPress/Classes/Services/AccountService.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#import <Foundation/Foundation.h>
@import WordPressDataObjC;
@import WordPressData;

NS_ASSUME_NONNULL_BEGIN

Expand Down
2 changes: 1 addition & 1 deletion WordPress/Classes/Services/AccountService.m
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#import "AccountService.h"
#import "WPAccount.h"
@import WordPressDataObjC;
@import WordPressData;
#import "Blog.h"
#import "BlogService.h"

Expand Down
2 changes: 1 addition & 1 deletion WordPress/Classes/Services/BlogService.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#import <Foundation/Foundation.h>
#import "Blog.h"
@import WordPressDataObjC;
@import WordPressData;

NS_ASSUME_NONNULL_BEGIN

Expand Down
2 changes: 1 addition & 1 deletion WordPress/Classes/Services/BlogService.m
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#import "Blog.h"
#import "WPAccount.h"
#import "AccountService.h"
@import WordPressDataObjC;
@import WordPressData;
#import "WPError.h"
#import "Media.h"
#import "PostCategoryService.h"
Expand Down
2 changes: 1 addition & 1 deletion WordPress/Classes/Services/CommentService.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#import <Foundation/Foundation.h>
#import "CoreDataService.h"
@import WordPressDataObjC;
@import WordPressData;

NS_ASSUME_NONNULL_BEGIN

Expand Down
2 changes: 1 addition & 1 deletion WordPress/Classes/Services/CommentService.m
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#import "CommentService.h"
#import "AccountService.h"
#import "Blog.h"
@import WordPressDataObjC;
@import WordPressData;
#import "ReaderPost.h"
#import "WPAccount.h"
#import "PostService.h"
Expand Down
2 changes: 1 addition & 1 deletion WordPress/Classes/Services/Facades/BlogSyncFacade.m
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#import "BlogSyncFacade.h"
@import WordPressDataObjC;
@import WordPressData;
#import "BlogService.h"
#import "AccountService.h"
#import "Blog.h"
Expand Down
2 changes: 1 addition & 1 deletion WordPress/Classes/Services/MediaService.m
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#import "AccountService.h"
#import "Media.h"
#import "WPAccount.h"
@import WordPressDataObjC;
@import WordPressData;
#import "Blog.h"
#import <MobileCoreServices/MobileCoreServices.h>
#import "WordPress-Swift.h"
Expand Down
2 changes: 1 addition & 1 deletion WordPress/Classes/Services/MenusService.m
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
#import "Menu.h"
#import "MenuItem.h"
#import "MenuLocation.h"
@import WordPressDataObjC;
@import WordPressData;
#import "PostService.h"
#import "WordPress-Swift.h"
@import WordPressKit;
Expand Down
2 changes: 1 addition & 1 deletion WordPress/Classes/Services/PostCategoryService.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#import <Foundation/Foundation.h>
@import WordPressDataObjC;
@import WordPressData;

NS_ASSUME_NONNULL_BEGIN

Expand Down
2 changes: 1 addition & 1 deletion WordPress/Classes/Services/PostCategoryService.m
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#import "PostCategoryService.h"
#import "PostCategory.h"
#import "Blog.h"
@import WordPressDataObjC;
@import WordPressData;
#import "WordPress-Swift.h"
@import WordPressKit;

Expand Down
2 changes: 1 addition & 1 deletion WordPress/Classes/Services/PostService.m
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#import "PostService.h"
#import "PostCategory.h"
#import "PostCategoryService.h"
@import WordPressDataObjC;
@import WordPressData;
#import "CommentService.h"
#import "MediaService.h"
#import "Media.h"
Expand Down
2 changes: 1 addition & 1 deletion WordPress/Classes/Services/PostTagService.m
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#import "PostTagService.h"
#import "Blog.h"
#import "PostTag.h"
@import WordPressDataObjC;
@import WordPressData;
#import "WordPress-Swift.h"
@import WordPressKit;

Expand Down
2 changes: 1 addition & 1 deletion WordPress/Classes/Services/Reader Post/ReaderPostService.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#import <Foundation/Foundation.h>
@import WordPressDataObjC;
@import WordPressData;

#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wnullability-completeness"
Expand Down
2 changes: 1 addition & 1 deletion WordPress/Classes/Services/Reader Post/ReaderPostService.m
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#import "ReaderPostService.h"

#import "AccountService.h"
@import WordPressDataObjC;
@import WordPressData;
#import "ReaderGapMarker.h"
#import "ReaderPost.h"
#import "ReaderSiteService.h"
Expand Down
2 changes: 1 addition & 1 deletion WordPress/Classes/Services/ReaderSiteService.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#import <Foundation/Foundation.h>
#import "ReaderTopicService.h"
@import WordPressDataObjC;
@import WordPressData;

typedef NS_ENUM(NSUInteger, ReaderSiteServiceError) {
ReaderSiteServiceErrorNotLoggedIn,
Expand Down
2 changes: 1 addition & 1 deletion WordPress/Classes/Services/ReaderSiteService.m
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#import "ReaderSiteService.h"

#import "AccountService.h"
@import WordPressDataObjC;
@import WordPressData;
#import "ReaderPostService.h"
#import "ReaderPost.h"
#import "WPAccount.h"
Expand Down
2 changes: 1 addition & 1 deletion WordPress/Classes/Services/ReaderTopicService.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#import <Foundation/Foundation.h>
#import "CoreDataService.h"
@import WordPressDataObjC;
@import WordPressData;

extern NSString * const ReaderTopicFreshlyPressedPathCommponent;

Expand Down
2 changes: 1 addition & 1 deletion WordPress/Classes/Services/ReaderTopicService.m
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#import "ReaderTopicService.h"

#import "AccountService.h"
@import WordPressDataObjC;
@import WordPressData;
#import "ReaderPost.h"
#import "ReaderPostService.h"
#import "WPAccount.h"
Expand Down
2 changes: 1 addition & 1 deletion WordPress/Classes/Services/ThemeService.h
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@import WordPressDataObjC;
@import WordPressData;

@class Blog;
@class Theme;
Expand Down
2 changes: 1 addition & 1 deletion WordPress/Classes/Services/ThemeService.m
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#import "Blog.h"
#import "Theme.h"
#import "WPAccount.h"
@import WordPressDataObjC;
@import WordPressData;
#import "WordPress-Swift.h"
@import WordPressKit;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#import "WPAnalyticsTrackerAutomatticTracks.h"
@import WordPressDataObjC;
@import WordPressData;
#import "AccountService.h"
#import "BlogService.h"
#import "WPAccount.h"
Expand Down
2 changes: 1 addition & 1 deletion WordPress/Classes/Utility/Analytics/WPAppAnalytics.m
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#import "WPAppAnalytics.h"

@import WordPressDataObjC;
@import WordPressData;
#import "WPAnalyticsTrackerWPCom.h"
#import "WPAnalyticsTrackerAutomatticTracks.h"
#import "WPTabBarController.h"
Expand Down
2 changes: 1 addition & 1 deletion WordPress/Classes/Utility/WPAuthTokenIssueSolver.m
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#import "WPAuthTokenIssueSolver.h"
#import "AccountService.h"
#import "BlogService.h"
@import WordPressDataObjC;
@import WordPressData;
#import "WPAccount.h"
#import "WordPress-Swift.h"

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#import "AccountService.h"
#import "BlogService.h"
#import "CommentsViewController.h"
@import WordPressDataObjC;
@import WordPressData;
#import "ReachabilityUtils.h"
#import "SiteSettingsViewController.h"
#import "SharingViewController.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

#import "Blog.h"
#import "BlogService.h"
@import WordPressDataObjC;
@import WordPressData;
#import "PostCategory.h"
#import "PostCategoryService.h"
#import "SettingsSelectionViewController.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
#import "MenuItemEditingFooterView.h"
#import "MenuItemSourceViewController.h"
#import "MenuItemTypeViewController.h"
@import WordPressDataObjC;
@import WordPressData;
#import "WordPress-Swift.h"

@import WordPressShared;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#import "MenuItemView.h"
#import "MenuItemInsertionView.h"
#import "MenuItemsVisualOrderingView.h"
@import WordPressDataObjC;
@import WordPressData;
#import "Menu+ViewDesign.h"
#import "WordPress-Swift.h"

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#import "MenuItemsViewController.h"
#import "MenuItemEditingViewController.h"
#import "Menu+ViewDesign.h"
@import WordPressDataObjC;
@import WordPressData;
#import "WPAppAnalytics.h"
#import "WordPress-Swift.h"

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#import "Media.h"
#import "SettingsSelectionViewController.h"
#import "SharingDetailViewController.h"
@import WordPressDataObjC;
@import WordPressData;
#import "MediaService.h"
#import "WordPress-Swift.h"

Expand Down
2 changes: 1 addition & 1 deletion WordPress/Classes/ViewRelated/Stats/StatsViewController.m
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#import "StatsViewController.h"
#import "Blog.h"
#import "WPAccount.h"
@import WordPressDataObjC;
@import WordPressData;
#import "BlogService.h"
#import "WordPress-Swift.h"
#import "WPAppAnalytics.h"
Expand Down
2 changes: 1 addition & 1 deletion WordPress/Classes/ViewRelated/System/WPTabBarController.m
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#import "WPTabBarController.h"

#import "AccountService.h"
@import WordPressDataObjC;
@import WordPressData;
#import "BlogService.h"
#import "Blog.h"

Expand Down
Loading