Skip to content

Conversation

wjrosa
Copy link
Contributor

@wjrosa wjrosa commented May 28, 2025

See #4360 (comment)

Changes proposed in this Pull Request:

This PR fixes the label displayed when running the PHP code coverage action. Currently, it should display the dynamic versions retrieved for WordPress and WooCommerce, but instead, it displays the raw JSON parser code:
448438605-1562ff3e-3dde-46c9-9574-b8214709792a

I am unsure why it is not displaying the value, but I believe it is because of the [0] part. So, I decided to use the policy identifiers instead.

Testing instructions

Code review.


  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Changelog entry

  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Comment

Comment

Post merge

@wjrosa wjrosa self-assigned this May 28, 2025
@wjrosa wjrosa marked this pull request as ready for review May 28, 2025 15:56
@wjrosa wjrosa requested review from a team and malithsen and removed request for a team May 28, 2025 15:56
@malithsen
Copy link
Contributor

@wjrosa I'm having trouble finding where the original label in your screenshot was displayed. Can you share a link to the action or log?

@wjrosa
Copy link
Contributor Author

wjrosa commented May 30, 2025

Now that you mentioned, @malithsen , I also could not find any PR with this issue 🤔. I can see it working correctly:
Screenshot 2025-05-30 at 11 11 31
PR: #4373

@daledupreez since you reported this, can you share a PR with the broken label please?

@daledupreez
Copy link
Contributor

Hi @wjrosa, apologies for the delay. The issue still looks like it is visible on #4260.

@wjrosa wjrosa enabled auto-merge (squash) June 4, 2025 19:34
@wjrosa wjrosa merged commit 612edcc into develop Jun 4, 2025
52 of 54 checks passed
@wjrosa wjrosa deleted the fix/code-coverage-workflow-label branch June 4, 2025 19:45
@daledupreez daledupreez added this to the 9.6.0 milestone Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants