Skip to content

Conversation

@wjrosa
Copy link
Contributor

@wjrosa wjrosa commented May 26, 2025

Changes proposed in this Pull Request:

This PR dynamically retrieves the versions of WooCommerce and WordPress when running the PHP code coverage action, so we don't have to keep updating the action manually every time we bump the minimum supported versions.

Testing instructions

Code review. Check if the tests are still passing. Confirm the code coverage action executed here successfully.

The random method added here to run the action will be removed before merging the PR.


  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Changelog entry

  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Comment

Comment

Post merge

@wjrosa wjrosa self-assigned this May 26, 2025
@wjrosa wjrosa mentioned this pull request May 26, 2025
6 tasks
@wjrosa wjrosa marked this pull request as ready for review May 26, 2025 17:27
@github-actions
Copy link

📈 PHP Unit Code Coverage Report

Package Line Rate Health
includes/class-wc-stripe-mode.php 100%
Summary 45% (7387 / 16358)

@wjrosa wjrosa requested a review from malithsen May 26, 2025 17:34
@wjrosa wjrosa mentioned this pull request May 26, 2025
6 tasks
Copy link
Contributor

@malithsen malithsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for updating this workflow to use the new actions!

@wjrosa wjrosa merged commit 61de727 into develop May 26, 2025
50 of 51 checks passed
@wjrosa wjrosa deleted the dev/making-code-coverage-use-dynamic-wp-wc-versions branch May 26, 2025 22:24
@daledupreez
Copy link
Contributor

@wjrosa, it looks like things are working, but the labels in GitHub aren't great. It may be worth considering a follow-up to make them more readable.
Screenshot 2025-05-28 at 16 16 03

@wjrosa
Copy link
Contributor Author

wjrosa commented May 28, 2025

@wjrosa, it looks like things are working, but the labels in GitHub aren't great. It may be worth considering a follow-up to make them more readable. Screenshot 2025-05-28 at 16 16 03

Thanks for flagging, Dale! I have fixed it here using the policy identifiers #4369. It should work in the original version, but I am not sure why it does not (maybe due to the [0] part). I found this working example in GH https://github.com/elastic/rally/blob/11439c5674521bf93b237091b72bd26f99552fe3/.github/workflows/ci.yml#L48

@daledupreez daledupreez added this to the 9.6.0 milestone Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants