This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Fixes transaction confirmations with the HttpProvider #3140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nivida
added
Enhancement
…destyle improved, and transaction confirmation handling in the Method class of the web3-core-method module
This was referenced Mar 31, 2020
nachomazzara
pushed a commit
to nachomazzara/web3.js
that referenced
this pull request
Jun 4, 2020
* confirmations are now only emitted if a new block is actually existing * CHANGELOG.md updated * CHANGELOG.md 'Added' section updated with the added types * build packages updated * istanbul updated because of the usage of 'async', contract.js test codestyle improved, and transaction confirmation handling in the Method class of the web3-core-method module * coveralls CI script updated * coverage paths updated in e2e.ganache.sh, e2e.geth.automine.sh, e2e.geth.instamine.sh
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back-ports #1239 which is listed in issue #3070.