Skip to content

Commit f6e8c9e

Browse files
nividanachomazzara
authored andcommitted
Fixes transaction confirmations with the HttpProvider (web3#3140)
* confirmations are now only emitted if a new block is actually existing * CHANGELOG.md updated * CHANGELOG.md 'Added' section updated with the added types * build packages updated * istanbul updated because of the usage of 'async', contract.js test codestyle improved, and transaction confirmation handling in the Method class of the web3-core-method module * coveralls CI script updated * coverage paths updated in e2e.ganache.sh, e2e.geth.automine.sh, e2e.geth.instamine.sh
1 parent 4d02c63 commit f6e8c9e

File tree

14 files changed

+1013
-1142
lines changed

14 files changed

+1013
-1142
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ Released with 1.0.0-beta.37 code base.
5858
- Add `eth.getChainId` method (#3113)
5959
- Minified file added to web3 package (#3131)
6060
- The transaction confirmation workflow can now be configured (#3130)
61+
- TypeScript type definitions added for all modules (#3132)
6162
- Bloom filters added to web3.utils (#3137)
6263

6364
### Fixed
@@ -78,3 +79,4 @@ Released with 1.0.0-beta.37 code base.
7879
- Signing issues #1998, #2033, and #1074 fixed (#3125)
7980
- Fix hexToNumber and hexToNumberString prefix validation (#3086)
8081
- The receipt will now returned on a EVM error (this got removed on beta.18) (#3129)
82+
- Fixes transaction confirmations with the HttpProvider (#3140)

package-lock.json

Lines changed: 650 additions & 614 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,8 @@
7272
}
7373
],
7474
"devDependencies": {
75-
"@babel/core": "^7.6.0",
76-
"@babel/preset-env": "^7.6.0",
75+
"@babel/core": "^7.6.4",
76+
"@babel/preset-env": "^7.6.3",
7777
"@types/bignumber.js": "^4.0.2",
7878
"@types/underscore": "^1.8.0",
7979
"@types/bn.js": "^4.11.5",
@@ -82,9 +82,9 @@
8282
"bluebird": "3.3.1",
8383
"bn.js": "^4.11.8",
8484
"bower": "1.8.8",
85-
"browserify": "^16.3.0",
85+
"browserify": "^16.5.0",
8686
"chai": "^4.2.0",
87-
"coveralls": "^3.0.4",
87+
"coveralls": "^3.0.7",
8888
"crypto-js": "^3.1.9-1",
8989
"del": "^4.1.1",
9090
"ethereumjs-common": "^1.3.2",
@@ -98,14 +98,14 @@
9898
"gulp-babel": "^8.0.0",
9999
"gulp-jshint": "^2.1.0",
100100
"gulp-rename": "^1.4.0",
101-
"gulp-replace": "^0.6.1",
101+
"gulp-replace": "^1.0.0",
102102
"gulp-streamify": "^1.0.2",
103103
"gulp-uglify": "^3.0.2",
104-
"istanbul": "^0.4.5",
104+
"istanbul": "^1.1.0-alpha.1",
105105
"istanbul-combine-updated": "^0.3.0",
106106
"jshint": "^2.10.2",
107107
"lerna": "^2.5.1",
108-
"mocha": "^6.1.4",
108+
"mocha": "^6.2.1",
109109
"sandboxed-module": "^2.0.3",
110110
"underscore": "^1.9.1",
111111
"vinyl-source-stream": "^2.0.0",

packages/web3-bzz/package-lock.json

Lines changed: 1 addition & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)