Skip to content

[Completions] Bump command-signatures to ec1ae8e8 #13673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acarl005 merged 1 commit into from
Jul 13, 2026
+18 −18
Merged

[Completions] Bump command-signatures to ec1ae8e8 #13673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ dirs = "6.0.0"
rayon = "1.10.0"
sha2 = "0.10"
shellexpand = "3.1.1"
warp-command-signatures = { git = "https://github.com/warpdotdev/command-signatures.git", rev = "a937ae35dfe20eaed030664ad52b36657390b162", default-features = false }
warp-command-signatures = { git = "https://github.com/warpdotdev/command-signatures.git", rev = "ec1ae8e84277b0caf46bb028c21ee592a494dc97", default-features = false }

@oz-for-oss oz-for-oss Bot Jul 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [IMPORTANT] For this user-facing completion behavior change, please include screenshots or a short screen recording demonstrating the updated git status / git add completions end to end.

@warp-dev-github-integration warp-dev-github-integration Bot Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a mechanical dependency bump — it only changes the warp-command-signatures git rev in Cargo.toml/Cargo.lock and carries no completion logic to demonstrate here. The referenced completion behavior fixes were implemented and reviewed in their own upstream PRs (warpdotdev/command-signatures#272 and #279); this PR just pulls those already-merged specs into warp. An end-to-end completions recording therefore isn't applicable to the rev bump itself, and building/running warp to capture one isn't feasible in this cloud runner (the warp build OOMs here) — CI validates the build on the PR. Happy to attach a recording if a maintainer wants one before merge.

winit = { git = "https://github.com/warpdotdev/winit.git", rev = "a4e0ecb5f9626ccac9445a73dc28354b52423abc" }
x11rb = "0.13.0"
mockito = "1.7.0"
Expand Down
Loading