[Completions] Bump command-signatures to ec1ae8e8#13673
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
|
@warp-dev-github-integration[bot] I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR updates warp-command-signatures to ec1ae8e8, with corresponding Cargo.lock updates for the git dependency and transitive package versions. No approved spec context was provided, and the security pass did not identify a changed-line security concern.
Concerns
- The PR describes user-facing completion behavior fixes, but the description does not include screenshots or a screen recording demonstrating the updated
git status/git addcompletions end to end.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| sha2 = "0.10" | ||
| shellexpand = "3.1.1" | ||
| warp-command-signatures = { git = "https://github.com/warpdotdev/command-signatures.git", rev = "a937ae35dfe20eaed030664ad52b36657390b162", default-features = false } | ||
| warp-command-signatures = { git = "https://github.com/warpdotdev/command-signatures.git", rev = "ec1ae8e84277b0caf46bb028c21ee592a494dc97", default-features = false } |
There was a problem hiding this comment.
git status / git add completions end to end.
There was a problem hiding this comment.
This is a mechanical dependency bump — it only changes the warp-command-signatures git rev in Cargo.toml/Cargo.lock and carries no completion logic to demonstrate here. The referenced completion behavior fixes were implemented and reviewed in their own upstream PRs (warpdotdev/command-signatures#272 and #279); this PR just pulls those already-merged specs into warp. An end-to-end completions recording therefore isn't applicable to the rev bump itself, and building/running warp to capture one isn't feasible in this cloud runner (the warp build OOMs here) — CI validates the build on the PR. Happy to attach a recording if a maintainer wants one before merge.
… in-merge i18n restore Merge origin/master into i18n. Resolved 5 conflict files; restored all i18n wraps disturbed by upstream refactor (no RU regression shipped). Conflicts resolved (8 blocks, 5 files): - app/src/terminal/block_list_element.rs: keep HEAD fn imports (attach_as_agent_mode_context_text/ask_ai_assistant_text); drop dead AgentViewState import (upstream removed its usage). - crates/warp_tui/src/slash_commands.rs: union imports; drop dead slash_command_selection_behavior + SlashCommandSelectionBehavior. - crates/warp_tui/src/ui.rs: upstream imports + re-add menu_label. - crates/warp_tui/src/warping_indicator.rs: upstream label-param refactor; drop now-dead menu_label import (format_credits kept). - crates/warp_tui/src/terminal_session_view.rs: upstream TuiSlashCommand enum dispatch + show_*_hint refactor; drop dead slash_command_is_submitted_as_prompt + slash_commands imports. i18n restore (in-merge, no deferred regression): - 5 dead HINT consts deleted (COMMAND_ALREADY_RUNNING/NEW_CONVERSATION/ SHELL_MODE/COPY_SELECTION/COPY_FAILED_HINT). - 4 call sites re-wrapped with menu_label (copy_failed x2, copied_hint, new_conversation_blocked); warping caller wraps both branches (summarizing/label). Line ~1103 already wrapped (cannot_run_command). - 2 new YAML keys (tui.footer.copy_failed, tui.warping.summarizing) en+ru. Gate: cargo check -p warp 0/0, cargo check -p warp_tui 0/0, cargo test -p i18n 12/12, rustfmt clean, en/ru parity 2071/2071. Plan: c9fb9851 (2 plan-review cycles, 8 atomic cycle-2 reviewers).
2 participants
Description
Updates
warp-command-signaturesto ec1ae8e8.Merged PRs
Changelog Entries for Stable
CHANGELOG-BUG-FIX: Fixed
git statuscompletion parsing for paths with spaces and renames, and completion of nested untracked files forgit add.Conversation: https://staging.warp.dev/conversation/b34001b4-4abb-4cb1-be9d-98f75676605e
Run: https://oz.staging.warp.dev/runs/019f5d4d-27c2-750d-823f-90a8b0a92b9c
This PR was generated with Oz.