Skip to content

Correct iconVariants and colorSchemes casing. Add NotificationOptions.iconVariants #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Correct iconVariants and colorSchemes casing. Add NotificationOptions.iconVariants #885

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
79982b4
Correct iconVariants and colorSchemes casing. Add NotificationOptions…
carlosjeurissen Oct 9, 2025
c8f6f25
Update proposals/dark_mode_extension_icons.md
carlosjeurissen Oct 9, 2025
38b914b
Update proposals/dark_mode_extension_icons.md
carlosjeurissen Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions proposals/dark_mode_extension_icons.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,12 +90,12 @@ const exampleProperties: {string: string | ImageData}[] = [
{
"16": darkImageData16,
"32": darkImageData32,
"color_schemes": ["dark"]
"colorSchemes": ["dark"]
},
{
"16": lightImageData16,
"32": lightImageData32,
"color_schemes": ["light"]
"colorSchemes": ["light"]
}
];

Expand All @@ -104,9 +104,20 @@ const createProperties = {variants: exampleProperties};
action.setIcon(createProperties);

// menus.*(), for supporting browsers.
const menusProperties = {icon_variants: exampleProperties};
const menusProperties = {iconVariants: exampleProperties};
menus.create(menusProperties);
menus.update(id, menusProperties);

// notifications.NotificationOptions
{
type: "basic",
iconUrl: "/icon.png",
iconVariants: exampleProperties
}

If `iconVariants` is specified, `iconUrl` will be ignored.

Note: In a past version of the proposal and in earlier implementations in Safari. `icon_variants` and `color_schemes` was used instead of `iconVariants` and `colorSchemes`.
```

A benefit of this new structure is that it's more resilient to future changes,
Expand Down Expand Up @@ -268,4 +279,4 @@ N/A.

## Future Work

N/A.
N/A.