Correct iconVariants and colorSchemes casing. Add NotificationOptions.iconVariants
#885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosjeurissen
changed the title
iconVariants and colorSchemes casing. Add NotificationOptions.iconVariants
carlosjeurissen
changed the title
iconVariants and colorSchemes casing. Add NotificationOptions.iconVariantsiconVariants and colorSchemes casing. Add NotificationOptions.iconVariants
xeenon
approved these changes
Oct 9, 2025
Co-authored-by: Timothy Hatcher <[email protected]>
Co-authored-by: Timothy Hatcher <[email protected]>
kiaraarose
approved these changes
Oct 9, 2025
|
@solomonkinard @oliverdunk considering the pending Chromium implementation, love to hear your thoughts. |
|
@xeenon after checking your webkit PR on the setIcon null fix (https://github.com/WebKit/WebKit/pull/52135/files), seems you are also handling setIcon({variants: null}), we may want to add this to the proposal as well. (Or introduce a more semantic version, like restoreIcon() or resetIcon() as proposed in #876 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in:
#229 (comment)
To align with other extension APIs like
scripting.registerContentScripts(), using camelCase when setting iconVariants instead of snake_case would align with existing patterns in webExtension API design.This PR also adds a note on
NotificationOptions.iconVariantsas alternative forNotificationOptions.iconUrl.