Use consistent set semantics for impression/conversion sites #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The empty set means match anything.
csharrison
approved these changes
Apr 9, 2025
| @@ -1214,12 +1214,17 @@ To perform <dfn>common matching logic</dfn>, given | |||
| 1. If |now| - |lookbackDays| is after |impression|'s [=impression/timestamp=], | |||
| [=iteration/continue=]. | |||
|
|
|||
| 1. If |impression|'s [=impression/conversion sites=] [=set/is empty|is not empty=] | |||
There was a problem hiding this comment.
Isn't it impossible to have an empty set?
There was a problem hiding this comment.
No, this PR currently allows there to be an empty set of conversion sites, unless I made a mistake somewhere.
Comment on lines
+613
to
+616
| The sites where [=conversions=] for this impression may occur, identified by | ||
| their domain names. The <a method for=PrivateAttribution>measureConversion()</a> | ||
| method will only attribute to this impression when called by one of the indicated | ||
| sites. If empty, any site will match. |
There was a problem hiding this comment.
Do we really want this to be empty? Is there any situation where it makes sense to avoid specifying this?
There was a problem hiding this comment.
If you'd prefer, we could instead make the empty list an error.
CC @csharrison
There was a problem hiding this comment.
How about we take this (which is unambiguously OK), then we can put the question about empty/not to the broader group.
This was referenced May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #134, #137, #138
Preview | Diff