Skip to content

Decide about how conversion site matching works #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martinthomson opened this issue May 1, 2025 · 0 comments
Open

Decide about how conversion site matching works #145

martinthomson opened this issue May 1, 2025 · 0 comments
Labels
discuss Needs working group discussion

Comments

@martinthomson
Copy link
Member

#139 defines an impression record that includes a set of conversion sites. This is probably a little unusual, in that many ads will only target actions on a single site (noting that site entails multiple origins).

There are two related questions to resolve related to how conversion site information is saved for impressions.

(1) Empty conversion sites set

Should it be possible to save an impression with an empty set of conversion sites?

The change in #139 allows that and says that any site can find and use that impression in its conversion logic.

The alternative is to force this set to be non-empty (as #56 does). What will decide this is whether it makes sense for impressions to be converted on any site, or if it is possible for an impression to be saved without knowing a priori where it might convert. Neither of these seem likely to me.

(2) Singular conversion site

It's definitely true that some ads could convert on multiple different sites, but if the set of conversion sites cannot be empty, we have another choice: we could decide that it is simpler overall to have the conversion site be a simple value, not a set.

The consequence of this is that impressions that might convert at multiple different locations would need to be saved once for each conversion site. If most ads only ever convert in one place, or even a very small number of places, that would result in a design that is simpler to implement and explain.

@martinthomson martinthomson added the discuss Needs working group discussion label May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Needs working group discussion
Projects
None yet
Development

No branches or pull requests

1 participant