Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation #3

Merged
merged 6 commits into from
Jan 24, 2024
Merged

Initial implementation #3

merged 6 commits into from
Jan 24, 2024

Conversation

bastjan
Copy link
Contributor

@bastjan bastjan commented Jan 12, 2024 •
edited
Loading

Summary

  • Implements an interactive, guided way to download and decrypt emergency credentials.
  • Implements a non-interactive/scriptable way to download and decrypt emergency credentials.
  • Both the interactive and non-interactive are e2e tested with test credentials and an expect script in the e2e folder.
  • Discovers the bucket configuration from passbolt
  • Easy installation using install.sh
  • Shows tokens on stdout and creates a kubeconfig from them.

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.

@bastjan bastjan added the enhancement New feature or request label Jan 12, 2024
@bastjan bastjan force-pushed the initial-implementation branch 5 times, most recently from cbff37a to 785c714 Compare January 24, 2024 13:33
@bastjan bastjan requested a review from a team January 24, 2024 13:40
@bastjan bastjan force-pushed the initial-implementation branch 2 times, most recently from 04375a9 to a5d84f0 Compare January 24, 2024 14:06
@bastjan bastjan force-pushed the initial-implementation branch from a5d84f0 to 14c197a Compare January 24, 2024 14:14
simu
simu approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Some nitpicks inline

@bastjan bastjan merged commit 60d3521 into main Jan 24, 2024
@bastjan bastjan deleted the initial-implementation branch January 24, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simu simu simu approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bastjan @simu