Skip to content

Commit a5d84f0

Browse files
committed
Hide private key entry
1 parent 785c714 commit a5d84f0

File tree

3 files changed

+17
-3
lines changed

3 files changed

+17
-3
lines changed

e2e/interactive.tcl

+7-1
Original file line numberDiff line numberDiff line change
@@ -23,17 +23,22 @@ file delete -force "em-$cluster_id"
2323
set ::env(EMR_CONFIG_DIR) [pwd]
2424

2525
log "Starting tool"
26-
spawn ../emergency-credentials-receive
26+
spawn ../emergency-credentials-receive -omit-token-output
2727
expect -exact "Welcome"
2828

2929
log "Expecting private key prompt in editor"
3030
expect -exact "Paste your Passbolt private key"
3131
sleep .1
3232
send -- "i"
33+
log "Omitting user private_key input"
34+
log_user 0
3335
send -- "$private_key"
3436
# Escape key
3537
send -- "\x1b"
3638
send -- ":x\r"
39+
expect "survey*written"
40+
log "private_key entry done"
41+
log_user 1
3742

3843
log "Expecting passphrase prompt"
3944
expect_prompt "Passbolt passphrase"
@@ -48,6 +53,7 @@ send -- "\r"
4853
log "Expecting to have valid credentials"
4954
expect -exact "2 buckets with credentials found"
5055
expect -exact "Emergency credentials found"
56+
expect -exact "OMITTED"
5157

5258
log "Expecting API endpoint prompt"
5359
expect_prompt "Provide API endpoint"

e2e/non-interactive.tcl

+2-1
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,13 @@ log "Starting tool"
1818
set ::env(EMR_PASSPHRASE) "$passphrase"
1919
set ::env(EMR_KUBERNETES_ENDPOINT) "$api_endpoint"
2020
exec -- jq --null-input --arg key "$private_key" {{passbolt_key: $key}} > config.yaml
21-
spawn ../emergency-credentials-receive "$cluster_id"
21+
spawn ../emergency-credentials-receive -omit-token-output "$cluster_id"
2222
expect -exact "Welcome"
2323

2424
log "Expecting to have valid credentials"
2525
expect -exact "2 buckets with credentials found"
2626
expect -exact "Emergency credentials found"
27+
expect -exact "OMITTED"
2728
expect eof
2829

2930
test_kubeconfig "em-$cluster_id"

main.go

+8-1
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,8 @@ var (
6464
tokenOutputStyle = lipgloss.NewStyle().Foreground(lipgloss.Color("#04B575"))
6565
boldStyle = lipgloss.NewStyle().Bold(true)
6666
isTerminal = term.IsTerminal(int(os.Stdout.Fd()))
67+
68+
omitTokenOutput bool
6769
)
6870

6971
func main() {
@@ -76,6 +78,7 @@ func main() {
7678

7779
flag.PrintDefaults()
7880
}
81+
flag.BoolVar(&omitTokenOutput, "omit-token-output", false, "omit token output to STDOUT")
7982
flag.Parse()
8083

8184
clusterId := flag.Arg(0)
@@ -280,7 +283,11 @@ func main() {
280283
lf("Emergency credentials found\n\n")
281284
for i, c := range emcreds {
282285
fmt.Println("# ", "Token", i)
283-
fmt.Println("# ", tokenOutputStyle.Render(c))
286+
if omitTokenOutput {
287+
fmt.Println(tokenOutputStyle.Render("*** OMITTED ***"))
288+
} else {
289+
fmt.Println(tokenOutputStyle.Render(c))
290+
}
284291
}
285292

286293
kep := os.Getenv("EMR_KUBERNETES_ENDPOINT")

0 commit comments

Comments
 (0)