Skip to content

feat: add bitpacked chunk offset child - #9940

Merged
mhk197 merged 1 commit into
mk/bitpacked-stack-02-cpu-layoutfrom
mk/bitpacked-stack-04-offset-child
Sep 23, 2026
Merged

mhk197 merged 1 commit into
mk/bitpacked-stack-02-cpu-layoutfrom
mk/bitpacked-stack-04-offset-child

Conversation

@mhk197

@mhk197 mhk197 commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

This change is now reviewed in #10005.

During the branch reorder, GitHub automatically marked this PR merged into the kernel branch. That state change did not merge these changes into develop.

@codspeed

codspeed Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

Merging this PR will regress 1 benchmark

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ 3 benchmarks measured no execution time

Nothing ran under measurement, usually because the compiler removed the code under test. These results are not comparable, so they count as unchanged.

Preventing compiler optimizations

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 3 improved benchmarks
❌ 1 regressed benchmark
✅ 2228 untouched benchmarks
⏩ 329 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation take[routing/same_chunk/primitive/nonnull/chunks=32/indices=1000] 185.1 µs 229.7 µs -19.39%
⚡ Simulation take_fsl_nullable_random[256, 10] 105.6 µs 49 µs ×2.2
⚡ Simulation allocate_drop_arrow[65536] 101.9 µs 90.7 µs +12.36%
⚡ WallTime filtered_owned_i64_avx512[OneNullInEight] 26 µs 23.6 µs +10.26%
⚠️ Simulation fixed_16_advancing_ptr_safe[100] < 1 ns < 1 ns N/A
⚠️ Simulation preverify_advancing_ptr_unchecked[1000] < 1 ns < 1 ns N/A
⚠️ Simulation preverify_advancing_ptr_unchecked[10000] < 1 ns < 1 ns N/A

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing mk/bitpacked-stack-04-offset-child (7c3472f) with mk/bitpacked-stack-03-width-child (afae8b0)

Open in CodSpeed

Footnotes

  1. 329 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Signed-off-by: "Matt Katz" <mhkatz97@gmail.com>
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
@mhk197
mhk197 force-pushed the mk/bitpacked-stack-04-offset-child branch from 7c3472f to ecd1bd3 Compare September 23, 2026 18:17
Base automatically changed from mk/bitpacked-stack-03-width-child to mk/bitpacked-stack-02-cpu-layout September 23, 2026 18:17
@mhk197
mhk197 merged commit ecd1bd3 into develop Sep 23, 2026
@mhk197
mhk197 deleted the mk/bitpacked-stack-04-offset-child branch September 23, 2026 18:17
@mhk197
mhk197 restored the mk/bitpacked-stack-04-offset-child branch September 23, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant