Skip to content

Move BitPacked serde logic from VTable to Plugin - #9937

Open
mhk197 wants to merge 2 commits into
developfrom
mk/bitpacked-stack-01-wire-boundary
Open

mhk197 wants to merge 2 commits into
developfrom
mk/bitpacked-stack-01-wire-boundary

Conversation

@mhk197

@mhk197 mhk197 commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Move metadata, serialization and deserialization of fastlanes.bitpacked into BitPackedPlugin. The VTable retains only the required error-returning serde methods and in-memory array validation. BitPackedPlugin is registered on the default session instead of the vtable-derived plugin by default.

Users must now register BitPackedPlugin instead of BitPacked on session.

This refactor is made in preparation for introducing a new version of BitPackedArray

@codspeed

codspeed Bot commented Sep 18, 2026

Copy link
Copy Markdown

Merging this PR will regress 3 benchmarks

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ 3 benchmarks measured no execution time

Nothing ran under measurement, usually because the compiler removed the code under test. These results are not comparable, so they count as unchanged.

Preventing compiler optimizations

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 4 improved benchmarks
❌ 3 regressed benchmarks
✅ 2225 untouched benchmarks
⏩ 329 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation take_fsl_random[128, 10] 32.7 µs 58.5 µs -44.11%
WallTime scalar_subtract_neon 12.2 µs 13.8 µs -11.48%
Simulation allocate_drop_arrow[65536] 90.7 µs 101.9 µs -11%
Simulation take_fsl_u64_random[64, 10] 53.7 µs 30.8 µs +74.59%
Simulation take_fsl_f16_random[256, 100] 141.2 µs 87.5 µs +61.44%
Simulation take_fsl_random[64, 100] 143.9 µs 124.9 µs +15.22%
WallTime filtered_owned_i64_avx512[OneNullInEight] 26 µs 22.9 µs +13.38%
⚠️ Simulation fixed_16_advancing_ptr_safe[100] < 1 ns < 1 ns N/A
⚠️ Simulation preverify_advancing_ptr_unchecked[1000] < 1 ns < 1 ns N/A
⚠️ Simulation preverify_advancing_ptr_unchecked[10000] < 1 ns < 1 ns N/A

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing mk/bitpacked-stack-01-wire-boundary (04fa22c) with develop (2c8c7ee)

Open in CodSpeed

Footnotes

  1. 329 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Signed-off-by: "Matt Katz" <mhkatz97@gmail.com>

Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Signed-off-by: "Matt Katz" <mhkatz97@gmail.com>
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
@mhk197
mhk197 force-pushed the mk/bitpacked-stack-01-wire-boundary branch from 349b196 to 04fa22c Compare September 23, 2026 17:31
@mhk197
mhk197 marked this pull request as ready for review September 23, 2026 17:37
@mhk197 mhk197 changed the title refactor: isolate bitpacked v1 serde in the plugin Move BitPacked serde logic from VTable to Plugin Sep 23, 2026
@mhk197
mhk197 removed this pull request from stack #9946 September 23, 2026 18:19
@mhk197
mhk197 added this pull request to stack #10006 September 23, 2026 18:22
@mhk197
mhk197 removed this pull request from stack #10006 September 23, 2026 19:43
@mhk197
mhk197 added this pull request to stack #10012 September 23, 2026 19:43

This branch was successfully deployed

1 active (outdated) deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/break A breaking API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant