feat[back-compat]: Add a script to upload fixtures to a repo#6993
Merged
joseph-isaacs merged 9 commits intodevelopfrom Mar 18, 2026
Merged
feat[back-compat]: Add a script to upload fixtures to a repo#6993joseph-isaacs merged 9 commits intodevelopfrom
joseph-isaacs merged 9 commits intodevelopfrom
Conversation
joseph-isaacs
added a commit
that referenced
this pull request
Mar 17, 2026
Add extract fixtures to the backtesting system. There is another PR that will change the way we actually write the file to a store [see #6993]. Focus only on the generated files and the data from each fixture. --------- Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Replaces the simple upload.py with a comprehensive Python CLI that manages fixture versions in S3 or local stores. Simplifies the Rust binary to a thin generate/check tool while Python handles versioning, manifest management, SHA-256 integrity, and parallel S3 uploads. Key changes: - Rust: single vortex-compat binary (generate + check), computes sha256 per fixture in fixtures.json, simplified fixture traits - Python: compat.py with generate, publish (--update for incremental), check, list, verify, and validate-manifest commands - Removed since field from manifests; sha256 computed by Rust - Parallel uploads via ThreadPoolExecutor - Interactive confirmation prompt with --yes bypass Signed-off-by: Joe Isaacs <joe@spiraldb.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
joseph-isaacs
force-pushed
the
ji/add-backcompa-cli
branch
from
99165ca to
2b3ddec
Compare
Merging this PR will not alter performance
Comparing 
Footnotes
|
joseph-isaacs
changed the title
0ax1
reviewed
Mar 18, 2026
vortex-test/compat-gen/DESIGN.md
Outdated
| list, binary, extension), degenerate cases (empty files, all-null, float | ||
| specials), partial reads / mmap. | ||
|
|
||
| **Dependency drift:** If a dependency like `tpchgen` silently changes output |
Contributor
There was a problem hiding this comment.
Should we pin tpchgen with a big comment then on an exact commit or version?
Contributor
There was a problem hiding this comment.
tpchgen = { version = "=2.0.2" }
tpchgen-arrow = { version = "=2.0.2" }
| }; | ||
|
|
||
| // Compare arrays. | ||
| assert_arrays_eq!(stored_array, fresh_array); |
Contributor
There was a problem hiding this comment.
If this fails this will prevent JSON output. Is it intended to fully exit the check?
Contributor
Author
There was a problem hiding this comment.
Ill come back to this if it becomes a problem
0ax1
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the final PR in initial creation of the back-compat testing rfc:
This PR updates the docs.
Add a script to upload, list and validate changes.