chore[compat]: more fixtures compressed#6986
Merged
joseph-isaacs merged 13 commits intodevelopfrom Mar 17, 2026
Merged
Conversation
Merging this PR will not alter performance
Comparing 
Footnotes
|
joseph-isaacs
force-pushed
the
ji/more-fixtures-compressed
branch
from
d0c58b8 to
4d26af1
Compare
Signed-off-by: Joe Isaacs <joe@spiraldb.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
joseph-isaacs
changed the title
0ax1
reviewed
Mar 17, 2026
| Ok(()) | ||
| } | ||
|
|
||
| struct ClickBenchHits5kFixture; |
Contributor
There was a problem hiding this comment.
We're testing: old writer → current reader vs current writer → current reader but not old writer → old reader vs current writer → current reader right?
0ax1
reviewed
Mar 17, 2026
0ax1
reviewed
Mar 17, 2026
0ax1
reviewed
Mar 17, 2026
0ax1
reviewed
Mar 17, 2026
0ax1
reviewed
Mar 17, 2026
| Ok(dest) | ||
| } | ||
|
|
||
| fn download_with_retries(url: &str) -> VortexResult<Bytes> { |
Contributor
There was a problem hiding this comment.
for a future follow up: there's rust crates that could wrap the retry logic
0ax1
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add extract fixtures to the backtesting system.
There is another PR that will change the way we actually write the file to a store [see https://github.com//pull/6993]. Focus only on the generated files and the data from each fixture.