-
Notifications
You must be signed in to change notification settings - Fork 63
Add new TPU recipes links of Llama and Qwen models #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @anthonsu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request expands the documentation for running large language models with vLLM by introducing new recipes for Llama 3.1 and Qwen3 models. It also enhances an existing Qwen2.5-VL guide, primarily focusing on integrating and clarifying instructions for TPU deployments. The changes aim to provide clearer, more comprehensive guidance for users leveraging vLLM on various accelerated computing stacks. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces new recipe documentation for Llama 3.1 and Qwen 3, with a focus on TPU deployment. It also effectively restructures the Qwen/Qwen2.5-VL.md file to logically separate TPU and GPU deployment instructions, which greatly improves the document's clarity. The changes are well-executed, and I have only a couple of minor suggestions to enhance consistency and readability in the Markdown files.
|
Hi @youkaichao @simon-mo, could you please help review this PR? It is on top of the PR from Karan. (I lack sufficient permissions to edit, so I drafted this new one to expedite the process.) Thank you! |
Signed-off-by: Anthony Su <[email protected]>
What is included:
Reconstruct recipes of Llama and Qwen to include new TPU recipe' links.
(This new PR is based on Add links to new TPU recipes #84. If this new PR looks good, once it is merge, we can have the old one closed.)