-
Notifications
You must be signed in to change notification settings - Fork 60
Add links to new TPU recipes #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @karan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the project's documentation by reorganizing the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new 'TPU Guides' section in the main README file and renames the existing 'Guides' section to 'GPU Guides' for better organization. The changes are clear and improve the structure of the documentation. I have one suggestion to enhance the clarity of the newly added links.
Signed-off-by: Karan Goel <[email protected]>
Signed-off-by: Karan Goel <[email protected]>
Signed-off-by: Karan Goel <[email protected]>
### Llama | ||
- [Llama4-Scout](Llama/Llama4-Scout.md) | ||
- [Llama3.3-70B](Llama/Llama3.3-70B.md) | ||
- [Llama3.1-70B on TPU (Trillium)](https://github.com/AI-Hypercomputer/tpu-recipes/tree/main/inference/trillium/vLLM/Llama3.1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm you can add them inside Llama/Llama3.3-70B.md
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Llama3.3-70B.md file targets GPUs. The second file's title indicates its distinct focus on TPU Trillium support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Llama3.3-70B.md file should target at this model. TPU support should be listed in this file.
We don't want the flat directory to explode into {model} x {hardware} matrix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TPU recipes are maintained in a separate repo and it's a lot of easier to keep them up to date there (the repo has other frameworks and hardware supported there too).
@simon-mo thoughts in @youkaichao's proposal of moving TPU links within the model file?
Closing in favor of #86 |
No description provided.