Skip to content

RSDK-11510 - stop truncating mdns uri #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 1, 2025
Merged

RSDK-11510 - stop truncating mdns uri #412

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0309cdb
stop truncating mdns uri
stuqdog Aug 1, 2025
4a40424
selective truncation
stuqdog Aug 1, 2025
2944730
Revert "selective truncation"
stuqdog Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/src/rpc/dial.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,8 +219,7 @@ Future<String> _searchMdns(String address) async {
} else if (event.type == BonsoirDiscoveryEventType.discoveryServiceResolved) {
final service = event.service! as ResolvedBonsoirService;
if (service.name == targetName && service.host != null) {
final host = service.host!.substring(0, service.host!.length - 1);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stuqdog I am VERY curious as to why we were doing this in the first place

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only clue I have: https://github.com/viamrobotics/digital-yacht-mobile/pull/155

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah good question! The service.host doesn't appear as an IP address on ios but as a human readable address, the operating theory is that it has a lingering . at the end of it that we wanted to strip. However, @Otterverse tested on ios as well and android and found that not stripping the trailing character allowed for successful connection on both ios and android. So I think this was a case of being over-cautious on iOS in a way that broke android.

localAddress = '$host:${service.port}';
localAddress = '${service.host!}:${service.port}';
}
}
});
Expand Down