RSDK-11510 - stop truncating mdns uri #412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuqdog
changed the title
This reverts commit 4a40424.
njooma
reviewed
Aug 1, 2025
| @@ -219,8 +219,7 @@ Future<String> _searchMdns(String address) async { | |||
| } else if (event.type == BonsoirDiscoveryEventType.discoveryServiceResolved) { | |||
| final service = event.service! as ResolvedBonsoirService; | |||
| if (service.name == targetName && service.host != null) { | |||
| final host = service.host!.substring(0, service.host!.length - 1); | |||
There was a problem hiding this comment.
@stuqdog I am VERY curious as to why we were doing this in the first place
There was a problem hiding this comment.
only clue I have: https://github.com/viamrobotics/digital-yacht-mobile/pull/155
There was a problem hiding this comment.
Yeah good question! The service.host doesn't appear as an IP address on ios but as a human readable address, the operating theory is that it has a lingering . at the end of it that we wanted to strip. However, @Otterverse tested on ios as well and android and found that not stripping the trailing character allowed for successful connection on both ios and android. So I think this was a case of being over-cautious on iOS in a way that broke android.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.