[AP] Generalized Argument Parsing and Added Target Density #3148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
VPR
AlexandreSinger
force-pushed
the
feature-ap-cli
branch
from
96c4fc9 to
e22cb5b
Compare
|
This did not change quality of results majorly. Some circuits minorly changed, but this resolved some hidden issues within the partial legalizer. I did a quick sweep on VTR and found that setting the CLB target density to 0.8 improved post-FL HPWL by 9.8% and post-FL CPD by 2.7%; however basically a tie for post-routed HPWL adn CPD Trying a 0.8 target density for LABs on Titan achieved similar results. I think more tuning is needed before we pull the trigger on a specific target density. For now, this option will make performing sweeps in the future much easier. |
The `appack_max_dist_th` cli option has a useful regex based interface which can be used in other parts of VPR, especially in AP. Generalized the interface so it can be used outside of the context of max distance thresholding. Used this general interface to pass in a target density per physical tile type. This spoofs the capacity into being smaller than it appears which tells the partial legalizer to not fill the tiles beyond the capacity. Setting the target density to interesting values revealed a bug in the partial legalizer regarding numerical precision when computing the prefix sum. Changed the underlying data type within the prefix sum class used into fixed-point which resolved the issue.
AlexandreSinger
force-pushed
the
feature-ap-cli
branch
from
e22cb5b to
1ba2d53
Compare
|
Thanks for the review @amin1377 , please let me know if you have any further comments! |
amin1377
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
appack_max_dist_thcli option has a useful regex based interface which can be used in other parts of VPR, especially in AP. Generalized the interface so it can be used outside of the context of max distance thresholding.Used this general interface to pass in a target density per physical tile type. This spoofs the capacity into being smaller than it appears which tells the partial legalizer to not fill the tiles beyond the capacity.
Setting the target density to interesting values revealed a bug in the partial legalizer regarding numerical precision when computing the prefix sum. Changed the underlying data type within the prefix sum class used into fixed-point which resolved the issue.